Use V8RecursionScope::MicrotaskSuppression at ChromeClinetImpl::postAccessibilityNotification

Source/web/ChromeClientImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 49 matching lines @@
 #include "WebPopupMenuInfo.h"
 #include "WebSettings.h"
 #include "WebSettingsImpl.h"
 #include "WebTextDirection.h"
 #include "WebUserGestureIndicator.h"
 #include "WebUserGestureToken.h"
 #include "WebViewClient.h"
 #include "WebViewImpl.h"
 #include "WebWindowFeatures.h"
 #include "bindings/v8/ScriptController.h"
+#include "bindings/v8/V8RecursionScope.h"
 #include "core/accessibility/AXObject.h"
 #include "core/accessibility/AXObjectCache.h"
 #include "core/dom/Document.h"
 #include "core/dom/DocumentFullscreen.h"
 #include "core/dom/Node.h"
 #include "core/events/KeyboardEvent.h"
 #include "core/events/MouseEvent.h"
 #include "core/events/WheelEvent.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/loader/DocumentLoader.h"
@@ skipping 591 matching lines @@
 {
     // The current history item is not updated yet.  That happens lazily when
     // WebFrame::currentHistoryItem is requested.
     WebFrameImpl* webframe = WebFrameImpl::fromFrame(node->document().frame());
     if (webframe->client())
         webframe->client()->didUpdateCurrentHistoryItem(webframe);
 }
 
 void ChromeClientImpl::postAccessibilityNotification(AXObject* obj, AXObjectCache::AXNotification notification)
 {
+    V8RecursionScope::MicrotaskSuppression scope;

[haraken, 2014/02/24 11:06:09]

hmm, this looks fragile. We don't want to add MicrotaskSuppression to all web/
methods that can potentially invoke Function::Call(), Script::Run() etc.

BTW, what is MicrotaskSuppression for? MicrotaskSuppression is doing nothing
except for checking recursion level. I think that V8 already has a mechanism to
throw an exception when a recursion level is exceeded, so probably can we simply
remove MicrotaskSuppression completely?

+
     // Alert assistive technology about the accessibility object notification.
     if (!obj)
         return;
     if (m_webView->client())
         m_webView->client()->postAccessibilityEvent(WebAXObject(obj), toWebAXEvent(notification));
 }
 
 String ChromeClientImpl::acceptLanguages()
 {
     return m_webView->client()->acceptLanguages();
@@ skipping 266 matching lines @@
 {
     return static_cast<NavigatorContentUtilsClient::CustomHandlersState>(m_webView->client()->isProtocolHandlerRegistered(scheme, baseURL, url));
 }
 
 void NavigatorContentUtilsClientImpl::unregisterProtocolHandler(const String& scheme, const WebCore::KURL& baseURL, const WebCore::KURL& url)
 {
     m_webView->client()->unregisterProtocolHandler(scheme, baseURL, url);
 }
 
 } // namespace blink