Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1775493002: Revert of Update Skia's YUV API (Closed)

Created:
4 years, 9 months ago by msarett
Modified:
4 years, 9 months ago
Reviewers:
scroggo, bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Update Skia's YUV API (patchset #5 id:160001 of https://codereview.chromium.org/1716523002/ ) Reason for revert: Blimp failures with manual roll in Chrome. Original issue's description: > Update Skia's YUV API > > We should match the recently designed API in SkCodec. > https://codereview.chromium.org/1549473003/ > > This requires changes in Chromium as well. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1716523002 > > Committed: https://skia.googlesource.com/skia/+/095d31c8a0eeb5d491febf064bc3c8a44e22b94f TBR=scroggo@google.com,reed@google.com,bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/1590f3b32890f6455b30494308633177b54db347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -272 lines) Patch
M include/codec/SkCodec.h View 5 chunks +26 lines, -5 lines 0 comments Download
M include/core/SkImageGenerator.h View 3 chunks +15 lines, -28 lines 0 comments Download
M include/core/SkPixelRef.h View 3 chunks +16 lines, -29 lines 0 comments Download
D include/core/SkYUVSizeInfo.h View 1 chunk +0 lines, -34 lines 0 comments Download
M src/codec/SkCodecImageGenerator.h View 2 chunks +8 lines, -3 lines 0 comments Download
M src/codec/SkCodecImageGenerator.cpp View 2 chunks +42 lines, -5 lines 0 comments Download
M src/codec/SkJpegCodec.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/codec/SkJpegCodec.cpp View 5 chunks +28 lines, -32 lines 0 comments Download
M src/core/SkImageCacherator.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M src/core/SkImageGenerator.cpp View 1 chunk +50 lines, -22 lines 0 comments Download
M src/core/SkPixelRef.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/core/SkYUVPlanesCache.h View 2 chunks +8 lines, -3 lines 0 comments Download
M src/gpu/GrYUVProvider.h View 2 chunks +18 lines, -16 lines 0 comments Download
M src/gpu/GrYUVProvider.cpp View 4 chunks +23 lines, -25 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M src/lazy/SkDiscardablePixelRef.h View 1 chunk +5 lines, -11 lines 0 comments Download
M tests/ImageGeneratorTest.cpp View 1 chunk +17 lines, -15 lines 0 comments Download
M tests/YUVCacheTest.cpp View 2 chunks +9 lines, -10 lines 0 comments Download
M tests/YUVTest.cpp View 3 chunks +12 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
msarett
Created Revert of Update Skia's YUV API
4 years, 9 months ago (2016-03-07 17:16:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775493002/1
4 years, 9 months ago (2016-03-07 17:16:44 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 17:16:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1590f3b32890f6455b30494308633177b54db347

Powered by Google App Engine
This is Rietveld 408576698