Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1775473002: docs: fix the numbering in "Converting an existing Mac checkout" section (Closed)

Created:
4 years, 9 months ago by tfarina
Modified:
4 years, 9 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

docs: fix the numbering in "Converting an existing Mac checkout" section Due to the code block in the second item, the Markdown engine is not smart enough to figure out that the next one is related to the other items and thus should be '3' not '1'. To fix this, we number the list ourselves rather than letting the Markdown engine do this work for us. BUG=None TEST=load the document in http://dillinger.io/ before this change, confirm it has the issue, then change it and confirm it has the right numbering for the list. R=sdefresne@chromium.org Committed: https://crrev.com/b8922b4284b443d82da4a36d7b6e73b40250a625 Cr-Commit-Position: refs/heads/master@{#379590}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M docs/ios_build_instructions.md View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
4 years, 9 months ago (2016-03-07 17:15:17 UTC) #1
sdefresne
lgtm
4 years, 9 months ago (2016-03-07 17:58:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775473002/1
4 years, 9 months ago (2016-03-07 17:59:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 18:24:57 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 18:26:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8922b4284b443d82da4a36d7b6e73b40250a625
Cr-Commit-Position: refs/heads/master@{#379590}

Powered by Google App Engine
This is Rietveld 408576698