Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1775453002: Replace base::Tuple in //storage with std::tuple (Closed)

Created:
4 years, 9 months ago by tzik
Modified:
4 years, 9 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace base::Tuple in //storage with std::tuple BUG=554987 Committed: https://crrev.com/28d2c4b0ffac71c1d84939c92fea651091971639 Cr-Commit-Position: refs/heads/master@{#379692}

Patch Set 1 #

Patch Set 2 : update #include #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -21 lines) Patch
M storage/browser/fileapi/copy_or_move_operation_delegate.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M storage/browser/fileapi/file_system_operation_impl.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M storage/browser/fileapi/file_system_operation_runner.cc View 1 4 chunks +4 lines, -3 lines 0 comments Download
M storage/browser/fileapi/obfuscated_file_util.cc View 1 11 chunks +14 lines, -13 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_stream_writer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M storage/browser/fileapi/task_runner_bound_observer_list.h View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775453002/1
4 years, 9 months ago (2016-03-07 16:35:22 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775453002/20001
4 years, 9 months ago (2016-03-07 16:40:20 UTC) #4
tzik
PTAL
4 years, 9 months ago (2016-03-07 17:06:15 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-07 17:51:10 UTC) #8
nhiroki
lgtm https://codereview.chromium.org/1775453002/diff/20001/storage/browser/fileapi/task_runner_bound_observer_list.h File storage/browser/fileapi/task_runner_bound_observer_list.h (right): https://codereview.chromium.org/1775453002/diff/20001/storage/browser/fileapi/task_runner_bound_observer_list.h#newcode14 storage/browser/fileapi/task_runner_bound_observer_list.h:14: #include "base/tuple.h" I see. We should have include ...
4 years, 9 months ago (2016-03-08 00:49:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775453002/20001
4 years, 9 months ago (2016-03-08 00:53:08 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 01:00:32 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 01:01:39 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/28d2c4b0ffac71c1d84939c92fea651091971639
Cr-Commit-Position: refs/heads/master@{#379692}

Powered by Google App Engine
This is Rietveld 408576698