Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1775353003: [wasm] Memory is exported on the module.exports object. (Closed)

Created:
4 years, 9 months ago by titzer
Modified:
4 years, 9 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Memory is exported on the module.exports object. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Committed: https://crrev.com/8e9c019bf2e65b26847d615c28fc91343f41aba1 Cr-Commit-Position: refs/heads/master@{#34621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M src/wasm/wasm-module.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M test/mjsunit/wasm/calls.js View 1 chunk +4 lines, -4 lines 0 comments Download
M test/mjsunit/wasm/instantiate-module-basic.js View 1 chunk +4 lines, -4 lines 0 comments Download
M test/mjsunit/wasm/module-memory.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/start-function.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
PTAL
4 years, 9 months ago (2016-03-09 13:20:28 UTC) #1
ahaas
lgtm
4 years, 9 months ago (2016-03-09 13:26:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775353003/1
4 years, 9 months ago (2016-03-09 13:29:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 13:31:27 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 13:33:02 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8e9c019bf2e65b26847d615c28fc91343f41aba1
Cr-Commit-Position: refs/heads/master@{#34621}

Powered by Google App Engine
This is Rietveld 408576698