Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1775353002: Add DCHECK for nullptr in gl bindings (Closed)

Created:
4 years, 9 months ago by mkollaro
Modified:
4 years, 9 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DCHECK for nullptr in gl bindings BUG=593666 Committed: https://crrev.com/51f03fb7c106cdbadb014dcba1bf6b570da928b7 Cr-Commit-Position: refs/heads/master@{#380651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+449 lines, -0 lines) Patch
M ui/gl/generate_bindings.py View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_autogen_egl.cc View 45 chunks +45 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_autogen_gl.cc View 277 chunks +323 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_autogen_glx.cc View 47 chunks +48 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_autogen_osmesa.cc View 11 chunks +11 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_autogen_wgl.cc View 18 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
mkollaro
4 years, 9 months ago (2016-03-09 09:37:00 UTC) #2
Ken Russell (switch to Gerrit)
The code change looks fine, but could you please file a bug describing the motivation ...
4 years, 9 months ago (2016-03-10 01:39:16 UTC) #3
mkollaro
On 2016/03/10 01:39:16, Ken Russell wrote: > The code change looks fine, but could you ...
4 years, 9 months ago (2016-03-10 10:49:41 UTC) #5
Ken Russell (switch to Gerrit)
Thanks. LGTM
4 years, 9 months ago (2016-03-10 19:51:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775353002/1
4 years, 9 months ago (2016-03-11 07:49:26 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/195296)
4 years, 9 months ago (2016-03-11 09:17:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775353002/1
4 years, 9 months ago (2016-03-11 16:13:22 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 16:46:49 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 16:48:13 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/51f03fb7c106cdbadb014dcba1bf6b570da928b7
Cr-Commit-Position: refs/heads/master@{#380651}

Powered by Google App Engine
This is Rietveld 408576698