Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 177533025: Add section on compressing pexe files for deployment. (Closed)

Created:
6 years, 9 months ago by Karl
Modified:
6 years, 9 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com, binji, Sam Clegg
Visibility:
Public.

Description

Add section on compressing pexe files for deployment. BUG=None R=binji@chromium.org, jfb@chromium.org, jvoung@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254489

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix nits in patch set 1. #

Patch Set 3 : Fix issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -10 lines) Patch
M native_client_sdk/doc_generated/devguide/devcycle/building.html View 1 2 3 chunks +38 lines, -10 lines 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/building.rst View 1 2 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Karl
PTAL. Thanks.
6 years, 9 months ago (2014-02-26 16:53:35 UTC) #1
JF
lgtm after typo fix. https://codereview.chromium.org/177533025/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst File native_client_sdk/src/doc/devguide/devcycle/building.rst (right): https://codereview.chromium.org/177533025/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst#newcode350 native_client_sdk/src/doc/devguide/devcycle/building.rst:350: Tool pncl-compress must be called ...
6 years, 9 months ago (2014-02-26 17:27:21 UTC) #2
jvoung (off chromium)
otherwise LGTM, thanks https://codereview.chromium.org/177533025/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst File native_client_sdk/src/doc/devguide/devcycle/building.rst (right): https://codereview.chromium.org/177533025/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst#newcode335 native_client_sdk/src/doc/devguide/devcycle/building.rst:335: pnacl-compress applies compression strategies that are ...
6 years, 9 months ago (2014-02-26 18:01:04 UTC) #3
Karl
https://codereview.chromium.org/177533025/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst File native_client_sdk/src/doc/devguide/devcycle/building.rst (right): https://codereview.chromium.org/177533025/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst#newcode335 native_client_sdk/src/doc/devguide/devcycle/building.rst:335: pnacl-compress applies compression strategies that are already built On ...
6 years, 9 months ago (2014-02-27 18:37:26 UTC) #4
Karl
The CQ bit was checked by kschimpf@google.com
6 years, 9 months ago (2014-03-03 16:26:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kschimpf@google.com/177533025/40001
6 years, 9 months ago (2014-03-03 16:27:22 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 16:44:29 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=53054
6 years, 9 months ago (2014-03-03 16:44:30 UTC) #8
Karl
Need a LGTM to checkin. PTAL. Thanks.
6 years, 9 months ago (2014-03-03 16:49:54 UTC) #9
binji
lgtm
6 years, 9 months ago (2014-03-03 17:21:13 UTC) #10
Karl
6 years, 9 months ago (2014-03-03 17:29:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 manually as r254489 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698