[turbofan] Frame elision for code stubs

src/compiler/code-stub-assembler.cc

Index: src/compiler/code-stub-assembler.cc
diff --git a/src/compiler/code-stub-assembler.cc b/src/compiler/code-stub-assembler.cc
index 2327ac66b9a2c75104ca387c6938169623431bc0..e350a578f78be19bb1a9030c0c338b1bae2c25f5 100644
--- a/src/compiler/code-stub-assembler.cc
+++ b/src/compiler/code-stub-assembler.cc
@@ -653,8 +653,7 @@ Node* CodeStubAssembler::ChangeFloat64ToTagged(Node* value) {
     } else {
       Node* pair = Int32AddWithOverflow(value32, value32);
       Node* overflow = Projection(1, pair);
-      Label if_overflow(this, Label::kDeferred), if_notoverflow(this),
-          if_join(this);
+      Label if_overflow(this, Label::kDeferred), if_notoverflow(this);

[Benedikt Meurer, 2016/03/30 04:00:25]

Meh C++ should warn about this, really. But this should be in a separate CL.

       Branch(overflow, &if_overflow, &if_notoverflow);
       Bind(&if_overflow);
       Goto(&if_valueisheapnumber);
@@ -662,7 +661,7 @@ Node* CodeStubAssembler::ChangeFloat64ToTagged(Node* value) {
       {
         Node* result = Projection(0, pair);
         var_result.Bind(result);
-        Goto(&if_join);
+        Goto(&if_valueisheapnumber);

[Benedikt Meurer, 2016/03/30 04:00:25]

This change looks completely unrelated and wrong to me. This way you'd even box
values in the Smi range into a HeapNumber. Why did you change this?

       }
     }
   }