[turbofan] Frame elision for code stubs

src/compiler/frame-elider.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/compiler/frame-elider.h"
 #include "src/base/adapters.h"
-#include "src/compiler/frame-elider.h"
+#include "src/compiler/linkage.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
 FrameElider::FrameElider(InstructionSequence* code) : code_(code) {}
 
-void FrameElider::Run() {
+void FrameElider::Run(const CallDescriptor* descriptor) {
   MarkBlocks();
   PropagateMarks();
   MarkDeConstruction();
 }
 
+bool IsDeoptimize(const Instruction* instr) {
+  return instr->arch_opcode() == ArchOpcode::kArchDeoptimize ||
+         FlagsModeField::decode(instr->opcode()) == kFlags_deoptimize;
+}
 
 void FrameElider::MarkBlocks() {
   for (InstructionBlock* block : instruction_blocks()) {
     if (block->needs_frame()) continue;
     for (int i = block->code_start(); i < block->code_end(); ++i) {
-      if (InstructionAt(i)->IsCall() ||
-          InstructionAt(i)->opcode() == ArchOpcode::kArchDeoptimize) {
+      if (InstructionAt(i)->IsCall() || IsDeoptimize(InstructionAt(i)) ||
+          InstructionAt(i)->arch_opcode() == ArchOpcode::kArchStackPointer) {
         block->mark_needs_frame();
         break;
       }
     }
   }
 }
 
 
 void FrameElider::PropagateMarks() {
-  while (PropagateInOrder() && PropagateReversed()) {
+  while (PropagateInOrder() || PropagateReversed()) {
   }
 }
 
 
 void FrameElider::MarkDeConstruction() {
   for (InstructionBlock* block : instruction_blocks()) {
     if (block->needs_frame()) {
       // Special case: The start block needs a frame.
       if (block->predecessors().empty()) {
         block->mark_must_construct_frame();
       }
       // Find "frame -> no frame" transitions, inserting frame
       // deconstructions.
+      // TODO(mtrofin): we currently have to deal with deferred blocks
+      // that branch to deferred on non-deferred blocks, and when
+      // the deferred path continues to need a frame, while the non-deferred
+      // one doesn't. To avoid penalizing the non-deferred path with the cost of
+      // deconstruction, we deconstruct and reconstruct on the deferred path.
+      // This is a bit hacky and inefficient (code size). Alternatively, we
+      // should insert a deferred block on the edge between the deferred block
+      // and the non-deferred one, so we may insert there the deconstruction.
+      bool makes_switch = false;
       for (RpoNumber& succ : block->successors()) {
         if (!InstructionBlockAt(succ)->needs_frame()) {
-          DCHECK_EQ(1U, block->SuccessorCount());
-          block->mark_must_deconstruct_frame();
+          makes_switch = true;
+          break;
+        }
+      }
+      if (!makes_switch) continue;
+
+      ArchOpcode last_opcode =
+          code_->InstructionAt(block->last_instruction_index())->arch_opcode();
+      if (last_opcode == kArchThrowTerminator ||
+          IsDeoptimize(code_->InstructionAt(block->last_instruction_index()))) {
+        continue;
+      }
+      block->mark_must_deconstruct_frame();
+      if (block->SuccessorCount() > 1) {
+        for (RpoNumber& succ : block->successors()) {
+          InstructionBlock* succ_block = InstructionBlockAt(succ);
+          if (succ_block->needs_frame() && succ_block->IsDeferred()) {
+            succ_block->mark_must_construct_frame();
+          }
+          DCHECK_IMPLIES(!succ_block->IsDeferred(), !succ_block->needs_frame());
         }
       }
     } else {
       // Find "no frame -> frame" transitions, inserting frame constructions.
       for (RpoNumber& succ : block->successors()) {
         if (InstructionBlockAt(succ)->needs_frame()) {
           DCHECK_NE(1U, block->SuccessorCount());
           InstructionBlockAt(succ)->mark_must_construct_frame();
         }
       }
@@ skipping 58 matching lines @@
 }
 
 
 Instruction* FrameElider::InstructionAt(int index) const {
   return code_->InstructionAt(index);
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8