Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: net/base/net_error_details.h

Issue 1775283002: [Domain Reliabiliy: net stack] Plumb received go away from server due to connection migration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add test in quic_stream_factory_test: go away with migration with port only Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_chromium_client_session.h » ('j') | net/quic/quic_chromium_client_session.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/net_error_details.h
diff --git a/net/base/net_error_details.h b/net/base/net_error_details.h
index 47efebeb9d90e17806ad24c8dc887ef7eb4efcbf..80d449fa056c242aa5ea7f9afcf082fbe2c8691d 100644
--- a/net/base/net_error_details.h
+++ b/net/base/net_error_details.h
@@ -16,12 +16,14 @@ struct NET_EXPORT NetErrorDetails {
NetErrorDetails()
: quic_broken(false),
quic_connection_error(QUIC_NO_ERROR),
- connection_info(HttpResponseInfo::CONNECTION_INFO_UNKNOWN) {}
+ connection_info(HttpResponseInfo::CONNECTION_INFO_UNKNOWN),
+ received_goaway_because_of_migrating_port(false) {}
NetErrorDetails(bool quic_broken, QuicErrorCode quic_connection_error)
: quic_broken(quic_broken),
quic_connection_error(quic_connection_error),
- connection_info(HttpResponseInfo::CONNECTION_INFO_UNKNOWN) {}
+ connection_info(HttpResponseInfo::CONNECTION_INFO_UNKNOWN),
+ received_goaway_because_of_migrating_port(false) {}
// True if all QUIC alternative services are marked broken for the origin.
bool quic_broken;
@@ -31,6 +33,9 @@ struct NET_EXPORT NetErrorDetails {
// Will be discarded by upper layers if the connection type can be fetched
// from response header from the server.
HttpResponseInfo::ConnectionInfo connection_info;
+ // True if receives a GoAway frame from the server due to connection
+ // migration with port change.
+ bool received_goaway_because_of_migrating_port;
Ryan Hamilton 2016/03/10 22:46:44 nit: since this is quic specific, it should probab
Zhongyi Shi 2016/03/11 03:56:32 maybe quic_port_migration_detected? I hoped to kee
};
} // namespace net
« no previous file with comments | « no previous file | net/quic/quic_chromium_client_session.h » ('j') | net/quic/quic_chromium_client_session.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698