Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: net/quic/quic_stream_factory_test.cc

Issue 1775283002: [Domain Reliabiliy: net stack] Plumb received go away from server due to connection migration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add test in quic_stream_factory_test: go away with migration with port only Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« net/quic/quic_http_stream.cc ('K') | « net/quic/quic_http_stream.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_stream_factory.h" 5 #include "net/quic/quic_stream_factory.h"
6 6
7 #include "base/run_loop.h" 7 #include "base/run_loop.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "base/thread_task_runner_handle.h" 9 #include "base/thread_task_runner_handle.h"
10 #include "net/base/test_data_directory.h" 10 #include "net/base/test_data_directory.h"
(...skipping 585 matching lines...) Expand 10 before | Expand all | Expand 10 after
596 596
597 session->OnGoAway(QuicGoAwayFrame()); 597 session->OnGoAway(QuicGoAwayFrame());
598 598
599 EXPECT_FALSE( 599 EXPECT_FALSE(
600 QuicStreamFactoryPeer::HasActiveSession(factory_.get(), host_port_pair_)); 600 QuicStreamFactoryPeer::HasActiveSession(factory_.get(), host_port_pair_));
601 601
602 EXPECT_TRUE(socket_data.AllReadDataConsumed()); 602 EXPECT_TRUE(socket_data.AllReadDataConsumed());
603 EXPECT_TRUE(socket_data.AllWriteDataConsumed()); 603 EXPECT_TRUE(socket_data.AllWriteDataConsumed());
604 } 604 }
605 605
606 TEST_P(QuicStreamFactoryTest, GoAwayForConnectionMigrationWithPortOnly) {
607 Initialize();
608 ProofVerifyDetailsChromium verify_details = DefaultProofVerifyDetails();
609 crypto_client_stream_factory_.AddProofVerifyDetails(&verify_details);
610
611 MockRead reads[] = {MockRead(SYNCHRONOUS, ERR_IO_PENDING, 0)};
612 SequencedSocketData socket_data(reads, arraysize(reads), nullptr, 0);
613 socket_factory_.AddSocketDataProvider(&socket_data);
614
615 QuicStreamRequest request(factory_.get());
616 EXPECT_EQ(ERR_IO_PENDING,
617 request.Request(host_port_pair_, privacy_mode_,
618 /*cert_verify_flags=*/0, url_, "GET", net_log_,
619 callback_.callback()));
620
621 EXPECT_EQ(OK, callback_.WaitForResult());
622 scoped_ptr<QuicHttpStream> stream = request.ReleaseStream();
623 EXPECT_TRUE(stream.get());
624
625 QuicChromiumClientSession* session =
626 QuicStreamFactoryPeer::GetActiveSession(factory_.get(), host_port_pair_);
627
628 session->OnGoAway(
629 QuicGoAwayFrame(QUIC_ERROR_MIGRATING_PORT, 0,
630 "peer connection migration due to port change only"));
631 NetErrorDetails details;
632 session->PopulateNetErrorDetails(&details);
Ryan Hamilton 2016/03/10 22:46:44 Can you also call stream->PopulateNetErrorDetails(
Zhongyi Shi 2016/03/11 03:56:32 Done.
633 EXPECT_TRUE(details.received_goaway_because_of_migrating_port);
634
635 EXPECT_FALSE(
636 QuicStreamFactoryPeer::HasActiveSession(factory_.get(), host_port_pair_));
637
638 EXPECT_TRUE(socket_data.AllReadDataConsumed());
639 EXPECT_TRUE(socket_data.AllWriteDataConsumed());
640 }
641
606 TEST_P(QuicStreamFactoryTest, Pooling) { 642 TEST_P(QuicStreamFactoryTest, Pooling) {
607 Initialize(); 643 Initialize();
608 ProofVerifyDetailsChromium verify_details = DefaultProofVerifyDetails(); 644 ProofVerifyDetailsChromium verify_details = DefaultProofVerifyDetails();
609 crypto_client_stream_factory_.AddProofVerifyDetails(&verify_details); 645 crypto_client_stream_factory_.AddProofVerifyDetails(&verify_details);
610 646
611 MockRead reads[] = {MockRead(SYNCHRONOUS, ERR_IO_PENDING, 0)}; 647 MockRead reads[] = {MockRead(SYNCHRONOUS, ERR_IO_PENDING, 0)};
612 SequencedSocketData socket_data(reads, arraysize(reads), nullptr, 0); 648 SequencedSocketData socket_data(reads, arraysize(reads), nullptr, 0);
613 socket_factory_.AddSocketDataProvider(&socket_data); 649 socket_factory_.AddSocketDataProvider(&socket_data);
614 650
615 HostPortPair server2(kServer2HostName, kDefaultServerPort); 651 HostPortPair server2(kServer2HostName, kDefaultServerPort);
(...skipping 3220 matching lines...) Expand 10 before | Expand all | Expand 10 after
3836 EXPECT_TRUE(stream2.get()); 3872 EXPECT_TRUE(stream2.get());
3837 3873
3838 EXPECT_TRUE(socket_data1.AllReadDataConsumed()); 3874 EXPECT_TRUE(socket_data1.AllReadDataConsumed());
3839 EXPECT_TRUE(socket_data1.AllWriteDataConsumed()); 3875 EXPECT_TRUE(socket_data1.AllWriteDataConsumed());
3840 EXPECT_TRUE(socket_data2.AllReadDataConsumed()); 3876 EXPECT_TRUE(socket_data2.AllReadDataConsumed());
3841 EXPECT_TRUE(socket_data2.AllWriteDataConsumed()); 3877 EXPECT_TRUE(socket_data2.AllWriteDataConsumed());
3842 } 3878 }
3843 3879
3844 } // namespace test 3880 } // namespace test
3845 } // namespace net 3881 } // namespace net
OLDNEW
« net/quic/quic_http_stream.cc ('K') | « net/quic/quic_http_stream.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698