src/hydrogen-bce.cc - Issue 177523002: Fix optimistic BCE to back off after deopt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-bce.cc

Issue 177523002: Fix optimistic BCE to back off after deopt (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen-bce.cc

diff --git a/src/hydrogen-bce.cc b/src/hydrogen-bce.cc

index 2514f7d259de8d63095bc416b5219762f8cca145..e1a28471273f75274a85056b2c78ff06dba8cf10 100644

--- a/src/hydrogen-bce.cc

+++ b/src/hydrogen-bce.cc

@@ -375,7 +375,8 @@ BoundsCheckBbData* HBoundsCheckEliminationPhase::PreProcessBlock(

check->DeleteAndReplaceWith(check->ActualValue());

} else if (data->BasicBlock() == bb) {

data->CoverCheck(check, offset);

- } else {

+ } else if (graph()->use_optimistic_licm() ||

+ bb->IsLoopSuccessorDominator()) {

int32_t new_lower_offset = offset < data->LowerOffset()

? offset

: data->LowerOffset();

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-3176.js » ('j') | no next file with comments »