chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm - Issue 1775223002: Prepare chrome/ for compilation with OS X 10.7 deployment target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm

Issue 1775223002: Prepare chrome/ for compilation with OS X 10.7 deployment target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compile errors. Fix null-window error. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm ('k') | chrome/browser/ui/cocoa/panels/panel_titlebar_view_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm b/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm

index 5acb2d8a6c6a9c61f218bd5c0a975c0ec7964740..582a2a24e641cb72d9957cf1bed278e80bbdc98d 100644

--- a/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm

@@ -9,6 +9,7 @@

#import "chrome/browser/ui/cocoa/info_bubble_window.h"

#import "chrome/browser/ui/cocoa/one_click_signin_view_controller.h"

#import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"

+#include "ui/base/cocoa/cocoa_base_utils.h"

namespace {

@@ -41,7 +42,7 @@ void PerformClose(OneClickSigninBubbleController* controller) {

const NSRect bounds = [appMenuButton bounds];

NSPoint anchorPoint = NSMakePoint(NSMidX(bounds), NSMaxY(bounds));

anchorPoint = [appMenuButton convertPoint:anchorPoint toView:nil];

- anchorPoint = [parentWindow convertBaseToScreen:anchorPoint];

+ anchorPoint = ui::ConvertPointFromWindowToScreen(parentWindow, anchorPoint);

// Create an empty window into which content is placed.

NSRect viewBounds = [[viewController_ view] bounds];