chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm - Issue 1775223002: Prepare chrome/ for compilation with OS X 10.7 deployment target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

Issue 1775223002: Prepare chrome/ for compilation with OS X 10.7 deployment target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compile errors. Fix null-window error. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm ('k') | chrome/browser/ui/cocoa/framed_browser_window.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

index b192160e4b1ae1001d837bac3a709310acbf1c37..a714d484e7c5c168878c73675b1dc6b30bd31fb8 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

@@ -23,6 +23,7 @@

#include "content/public/browser/notification_details.h"

#include "content/public/browser/notification_source.h"

#include "extensions/browser/notification_types.h"

+#include "ui/base/cocoa/cocoa_base_utils.h"

#include "ui/base/cocoa/window_size_constants.h"

using content::BrowserContext;

@@ -176,7 +177,7 @@ class ExtensionPopupNotificationBridge : public content::NotificationObserver {

if (!window.get())

return nil;

- anchoredAt = [parentWindow convertBaseToScreen:anchoredAt];

+ anchoredAt = ui::ConvertPointFromWindowToScreen(parentWindow, anchoredAt);

if ((self = [super initWithWindow:window

parentWindow:parentWindow

anchoredAt:anchoredAt])) {