chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm - Issue 1775223002: Prepare chrome/ for compilation with OS X 10.7 deployment target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

Issue 1775223002: Prepare chrome/ for compilation with OS X 10.7 deployment target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compile errors. Fix null-window error. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm b/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

index 118e94a4b76e89b32bae316754f5978796066043..3f97173ebd586de502c3e41e5576aec843711d5f 100644

--- a/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

@@ -31,6 +31,7 @@

#include "grit/theme_resources.h"

#import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSAnimation+Duration.h"

#include "ui/base/cocoa/appkit_utils.h"

+#include "ui/base/cocoa/cocoa_base_utils.h"

#include "ui/base/material_design/material_design_controller.h"

NSString* const kBrowserActionVisibilityChangedNotification =

@@ -1048,7 +1049,7 @@ void ToolbarActionsBarBridge::ShowExtensionMessageBubble(

NSPoint anchor = [self popupPointForView:anchorView

withBounds:[anchorView bounds]];

- anchor = [[containerView_ window] convertBaseToScreen:anchor];

+ anchor = ui::ConvertPointFromWindowToScreen([containerView_ window], anchor);

activeBubble_ = [[ToolbarActionsBarBubbleMac alloc]

initWithParentWindow:[containerView_ window]

anchorPoint:anchor