chrome/browser/ui/cocoa/base_bubble_controller.mm - Issue 1775223002: Prepare chrome/ for compilation with OS X 10.7 deployment target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/base_bubble_controller.mm

Issue 1775223002: Prepare chrome/ for compilation with OS X 10.7 deployment target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compile errors. Fix null-window error. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/autofill/save_card_bubble_view_bridge.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/base_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/base_bubble_controller.mm b/chrome/browser/ui/cocoa/base_bubble_controller.mm

index a2529978691441dc188fe68c2117233298ebf866..3d84e032e2da291255debc82894c7ea27f2cc2f0 100644

--- a/chrome/browser/ui/cocoa/base_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/base_bubble_controller.mm

@@ -16,6 +16,7 @@

#import "chrome/browser/ui/cocoa/info_bubble_window.h"

#import "chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h"

#include "components/bubble/bubble_controller.h"

+#include "ui/base/cocoa/cocoa_base_utils.h"

@interface BaseBubbleController (Private)

- (void)registerForNotifications;

@@ -68,7 +69,7 @@

NSRect bounds = [view convertRect:[view bounds] toView:nil];

NSPoint anchor = NSMakePoint(NSMinX(bounds) + offset.x,

NSMinY(bounds) + offset.y);

- anchor = [window convertBaseToScreen:anchor];

+ anchor = ui::ConvertPointFromWindowToScreen(window, anchor);

return [self initWithWindowNibPath:nibPath

parentWindow:window

anchoredAt:anchor];