chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm - Issue 1775223002: Prepare chrome/ for compilation with OS X 10.7 deployment target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm

Issue 1775223002: Prepare chrome/ for compilation with OS X 10.7 deployment target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compile errors. Fix null-window error. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.mm ('k') | chrome/browser/ui/cocoa/autofill/save_card_bubble_view_bridge.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm b/chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm

index 3c8c92bd093751f1bfb3658dd2e83a04102fb4cf..c072c34da652ac675ac4a9c5d48eb79847c409b0 100644

--- a/chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm

+++ b/chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm

@@ -17,6 +17,7 @@

#import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"

#include "content/public/browser/web_contents.h"

#include "skia/ext/skia_utils_mac.h"

+#include "ui/base/cocoa/cocoa_base_utils.h"

#import "ui/base/cocoa/controls/hyperlink_button_cell.h"

#include "ui/base/cocoa/window_size_constants.h"

#include "ui/native_theme/native_theme.h"

@@ -235,9 +236,8 @@ void NewCreditCardBubbleCocoa::Show() {

anchor_point.y = NSMaxY([anchor_view bounds]) - anchor_point.y;

anchor_point = [anchor_view convertPoint:anchor_point toView:nil];

- NSRect frame = NSZeroRect;

- frame.origin = anchor_point;

- anchor_point = [parent_window convertBaseToScreen:anchor_point];

+ anchor_point =

+ ui::ConvertPointFromWindowToScreen(parent_window, anchor_point);

[bubbleController_ showAtAnchor:anchor_point];

}