chrome/browser/ui/cocoa/autofill/autofill_section_container.mm - Issue 1775223002: Prepare chrome/ for compilation with OS X 10.7 deployment target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_section_container.mm

Issue 1775223002: Prepare chrome/ for compilation with OS X 10.7 deployment target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compile errors. Fix null-window error. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/autofill/autofill_details_container.mm ('k') | chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/autofill/autofill_section_container.mm

diff --git a/chrome/browser/ui/cocoa/autofill/autofill_section_container.mm b/chrome/browser/ui/cocoa/autofill/autofill_section_container.mm

index 432582efe1444c5dddb3be128d8b507e924ace1d..320cc9d76e8092b1f6bf54824d3bda58b43bec78 100644

--- a/chrome/browser/ui/cocoa/autofill/autofill_section_container.mm

+++ b/chrome/browser/ui/cocoa/autofill/autofill_section_container.mm

@@ -9,6 +9,7 @@

#include <algorithm>

#include "base/mac/foundation_util.h"

+#include "base/mac/sdk_forward_declarations.h"

#include "base/strings/sys_string_conversions.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/ui/autofill/autofill_dialog_view_delegate.h"

@@ -405,8 +406,7 @@ bool ShouldOverwriteComboboxes(autofill::DialogSection section,

// Get the frame rectangle for the designated field, in screen coordinates.

NSRect textFrameInScreen = [field convertRect:[field bounds] toView:nil];

- textFrameInScreen.origin =

- [[field window] convertBaseToScreen:textFrameInScreen.origin];

+ textFrameInScreen = [[field window] convertRectToScreen:textFrameInScreen];

// And adjust for gfx::Rect being flipped compared to OSX coordinates.

NSScreen* screen = [[NSScreen screens] firstObject];