Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1775203002: Add SkDrawPosTextHCommand JSON, fix skiaserve build. (Closed)

Created:
4 years, 9 months ago by bungeman-skia
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add SkDrawPosTextHCommand JSON, fix skiaserve build. Adds SkDrawPosTextHCommand ::fromJSON and ::toJSON. Both SkDrawPosTextCommand and SkDrawPosTextHCommand's ::toJSON write the correct number of positions, preventing reading uninitialized memory. The microhttpd build is now done in the build tree as opposed to in a temporary directory. The microhttpd build script uses os.path.join so that absolute paths do not confuse the build. This allows compatibility with the cmake gyp generator as CMake likes to pass absolute paths. The microhttpd gyp target is now marked as 'none' since it is not a 'static_library' target (which directs gyp to compile sources into a static library). The dependencies to the action are updated to the minimum required for sane re-building. The everything gyp target now depends on the skiaserve gyp target. This means that when using skia_build_server=1, building 'most' will build skiaserve, but when skia_build_server is not defined the skiaserve target will still be available if specified manually. The old json.gyp is removed as it currently does not build anything. All of the files currently referenced by it as sources no longer exist. Committed: https://skia.googlesource.com/skia/+/51190df040c5a81bb82b9cd5b95f07a39d0e602b

Patch Set 1 #

Patch Set 2 : More build fixes. #

Patch Set 3 : Fix position count, always define target. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -43 lines) Patch
M gyp/everything.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
D gyp/json.gyp View 1 chunk +0 lines, -29 lines 0 comments Download
M gyp/microhttpd.gyp View 1 2 chunks +6 lines, -4 lines 0 comments Download
M gyp/most.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libmicrohttpd/build.py View 1 2 chunks +12 lines, -8 lines 0 comments Download
M tools/debugger/SkDrawCommand.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/debugger/SkDrawCommand.cpp View 1 2 3 chunks +33 lines, -1 line 0 comments Download

Messages

Total messages: 22 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775203002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775203002/40001
4 years, 9 months ago (2016-03-09 04:02:43 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 04:17:14 UTC) #13
bungeman-skia
I used skiaserve today and started fixing things...
4 years, 9 months ago (2016-03-09 04:18:25 UTC) #15
joshualitt
On 2016/03/09 04:18:25, bungeman1 wrote: > I used skiaserve today and started fixing things... LGTM, ...
4 years, 9 months ago (2016-03-09 14:09:46 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775203002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775203002/40001
4 years, 9 months ago (2016-03-09 15:41:56 UTC) #20
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 15:42:57 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/51190df040c5a81bb82b9cd5b95f07a39d0e602b

Powered by Google App Engine
This is Rietveld 408576698