Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1775193002: Fix "[runtime] Unify and simplify how frames are marked" for embedded constant pools. (Closed)

Created:
4 years, 9 months ago by MTBrandyberry
Modified:
4 years, 9 months ago
Reviewers:
michael_dawson, danno
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix "[runtime] Unify and simplify how frames are marked" for embedded constant pools. Avoid hard-coding fp offset to marker in StandardFrame::IterateCompiledFrame. R=danno@chromium.org, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/40a9b8d170b1fd2dda96ee4b89222532e3dfbb59 Cr-Commit-Position: refs/heads/master@{#34623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/frames.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
PTAL
4 years, 9 months ago (2016-03-08 23:29:55 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775193002/1
4 years, 9 months ago (2016-03-08 23:30:12 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-08 23:52:40 UTC) #5
danno
lgtm
4 years, 9 months ago (2016-03-09 10:26:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775193002/1
4 years, 9 months ago (2016-03-09 14:34:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 14:36:30 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 14:38:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40a9b8d170b1fd2dda96ee4b89222532e3dfbb59
Cr-Commit-Position: refs/heads/master@{#34623}

Powered by Google App Engine
This is Rietveld 408576698