Re-land: Enable XFA-Forms for the PDFium plugin.

Re-land: Enable XFA-Forms for the PDFium plugin.

This is a change to gather stability, performance, and size
data and will be rolled back by 2016-03-18.

This is the gyp portion of the change; the GN variables
controlling the same things currently reside in the pdfium
product itsef.

Original Review URL: https://codereview.chromium.org/1761673002

Cr-Commit-Position: refs/heads/master@{#379622}
(cherry picked from commit afa43e7fa9754cff9ceb6969c665830a79a84c5b)

Committed: https://crrev.com/1e379580207e1bc923773ed8cf2f2fa9cc020394
Cr-Commit-Position: refs/heads/master@{#380444}

[Tom Sepez, 2016-03-08 22:01:54]

tsepez@chromium.org changed reviewers:
+ thakis@chromium.org

[Tom Sepez, 2016-03-08 22:01:55]

Nico, we think we've fixed the issues that caused the revert.  Thanks.

Blocked on https://codereview.chromium.org/1781493002/

[Nico, 2016-03-08 22:06:29]

lgtm

Can you add a win_clang_dbg or win_clang_rel try bot once the blocker is in?

[Tom Sepez, 2016-03-09 04:59:52]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-09 05:00:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1775173002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1775173002/1

[commit-bot: I haz the power, 2016-03-09 06:29:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 06:29:57]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-03-09 18:42:36]

On 2016/03/09 06:29:57, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

Hey Nico, the win_clang bot failures look to be skia, not PDFium.  Known issue?

[Nico, 2016-03-09 18:51:08]

No, didn't check the bots today yet :-( Complained on
https://codereview.chromium.org/1779623002/, will hopefully be resolved soon.
Sorry!

[Nico, 2016-03-10 02:56:07]

Looks like the clang try jobs are happy now (skia guys fixed the skia problem
earlier). Land land land :-)

[Tom Sepez, 2016-03-10 03:36:38]

On 2016/03/10 02:56:07, Nico wrote:
> Looks like the clang try jobs are happy now (skia guys fixed the skia problem
> earlier). Land land land :-)

Thanks.  I'll hit the cq button first thing Thurs. AM (I want to be around if it
goes off the rails again).

[Tom Sepez, 2016-03-10 16:41:18]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-03-10 16:41:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1775173002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1775173002/1

[commit-bot: I haz the power, 2016-03-10 19:20:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-10 19:22:44]

Description was changed from

==========
Re-land: Enable XFA-Forms for the PDFium plugin.

This is a change to gather stability, performance, and size
data and will be rolled back by 2016-03-18.

This is the gyp portion of the change; the GN variables
controlling the same things currently reside in the pdfium
product itsef.

Original Review URL: https://codereview.chromium.org/1761673002

Cr-Commit-Position: refs/heads/master@{#379622}
(cherry picked from commit afa43e7fa9754cff9ceb6969c665830a79a84c5b)
==========

to

==========
Re-land: Enable XFA-Forms for the PDFium plugin.

This is a change to gather stability, performance, and size
data and will be rolled back by 2016-03-18.

This is the gyp portion of the change; the GN variables
controlling the same things currently reside in the pdfium
product itsef.

Original Review URL: https://codereview.chromium.org/1761673002

Cr-Commit-Position: refs/heads/master@{#379622}
(cherry picked from commit afa43e7fa9754cff9ceb6969c665830a79a84c5b)

Committed: https://crrev.com/1e379580207e1bc923773ed8cf2f2fa9cc020394
Cr-Commit-Position: refs/heads/master@{#380444}
==========

[commit-bot: I haz the power, 2016-03-10 19:22:46]

Patchset 1 (id:??) landed as
https://crrev.com/1e379580207e1bc923773ed8cf2f2fa9cc020394
Cr-Commit-Position: refs/heads/master@{#380444}

[brucedawson, 2016-03-11 01:32:34]

On 2016/03/10 19:22:46, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/1e379580207e1bc923773ed8cf2f2fa9cc020394
> Cr-Commit-Position: refs/heads/master@{#380444}

This broke VS 2015. I opened crbug.com/593996. We should be able to fix the
issue and move forwards so I don't think we need to revert. Any help would be
appreciated.

[shinyak, 2016-03-11 02:53:00]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1784113002/ by shinyak@chromium.org.

The reason for reverting is: Speculative revert for too long compile time.