Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1775163005: [crankshaft] Add support for comparing with indirect undetectable values (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Add support for comparing with indirect undetectable values If left or right is guaranteed at compile-time to be an undetectable object, use HIsUndetectableAndBranch on the other side. BUG= Committed: https://crrev.com/457bbdc4b3fbec9bd1c0d95c93976b8d2faa1576 Cr-Commit-Position: refs/heads/master@{#34616}

Patch Set 1 #

Patch Set 2 : fix, see https://codereview.chromium.org/1774273002/ #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M src/crankshaft/hydrogen.cc View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-09 09:36:31 UTC) #2
Jarin
lgtm.
4 years, 9 months ago (2016-03-09 10:11:15 UTC) #3
Jarin
The instance-type-based version lgtm, too.
4 years, 9 months ago (2016-03-09 10:52:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775163005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775163005/80001
4 years, 9 months ago (2016-03-09 11:57:07 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-09 12:40:44 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 12:40:55 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/457bbdc4b3fbec9bd1c0d95c93976b8d2faa1576
Cr-Commit-Position: refs/heads/master@{#34616}

Powered by Google App Engine
This is Rietveld 408576698