Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1775163003: Force RevisionState.commit_hash to be a str. (Closed)

Created:
4 years, 9 months ago by qyearsley
Modified:
4 years, 9 months ago
Reviewers:
prasadv
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Force RevisionState.commit_hash to be a str. BUG=592674 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299165

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M scripts/slave/recipe_modules/auto_bisect/revision_state.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
qyearsley
I could also explicitly put the step name in str() below in this file as ...
4 years, 9 months ago (2016-03-08 22:56:35 UTC) #2
prasadv
lgtm
4 years, 9 months ago (2016-03-09 00:08:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775163003/1
4 years, 9 months ago (2016-03-09 00:37:21 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 00:40:59 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299165

Powered by Google App Engine
This is Rietveld 408576698