Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 1775143003: Reland of Add browser tests for FetchEvent.request.mode/credentials in the service worker (Closed)

Created:
4 years, 9 months ago by horo
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add browser tests for FetchEvent.request.mode/credentials in the service worker (patchset #1 id:1 of https://codereview.chromium.org/1739643002/ ) Reason for revert: Bug fixed cl landed: https://codereview.chromium.org/1762893002/ Original issue's description: > Revert of Add browser tests for FetchEvent.request.mode/credentials in the service worker (patchset #5 id:120001 of https://codereview.chromium.org/1665453003/ ) > > Reason for revert: > https://codereview.chromium.org/1665533003/ introduced a security bug. > > Original issue's description: > > Add browser tests for FetchEvent.request.mode/credentials in the service worker > > > > This CL adds browser_tests to check the fetch request mode and > > credentials mode in the service worker for the follwing requests. > > > > - <embed src="test.pdf"> > > Fetched in MimeHandlerViewContainer::OnReady(). > > - <link rel="manifest" href="manifest.json"> > > Fetched in ManifestFetcher::Start(). > > - PPAPI's pp::URLLoader. > > Fetched in PepperURLLoaderHost::InternalOnHostMsgOpen(). > > > > This CL depends on https://codereview.chromium.org/1665533003/. > > > > BUG=576534, 543895 > > > > Committed: https://crrev.com/bcc7a2056bac1159aa480a8fb9355da98f84424c > > Cr-Commit-Position: refs/heads/master@{#376704} > > TBR=jochen@chromium.org,bradnelson@chromium.org,bradnelson@google.com,nhiroki@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=576534, 543895 > > Committed: https://crrev.com/50ba0ec970300e054957e23e547a2a0d6759afc8 > Cr-Commit-Position: refs/heads/master@{#377532} TBR=jochen@chromium.org,bradnelson@chromium.org,bradnelson@google.com,nhiroki@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=576534, 543895 Committed: https://crrev.com/61f3f4f037aca857735769cda129e18e38e8853e Cr-Commit-Position: refs/heads/master@{#380014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+504 lines, -0 lines) Patch
M chrome/browser/chrome_service_worker_browsertest.cc View 4 chunks +389 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/data/nacl/BUILD.gn View 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/test/data/nacl/nacl_test_data.gyp View 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/test/data/nacl/pnacl_url_loader/pnacl_url_loader.cc View 1 chunk +60 lines, -0 lines 0 comments Download
A chrome/test/data/nacl/pnacl_url_loader/pnacl_url_loader.html View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
horo
Created Reland of Add browser tests for FetchEvent.request.mode/credentials in the service worker
4 years, 9 months ago (2016-03-08 23:36:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775143003/1
4 years, 9 months ago (2016-03-08 23:37:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775143003/1
4 years, 9 months ago (2016-03-09 00:01:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775143003/1
4 years, 9 months ago (2016-03-09 00:31:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775143003/1
4 years, 9 months ago (2016-03-09 01:01:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 01:26:23 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 01:27:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61f3f4f037aca857735769cda129e18e38e8853e
Cr-Commit-Position: refs/heads/master@{#380014}

Powered by Google App Engine
This is Rietveld 408576698