Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1424)

Issue 1775143002: Revert of SkPDF: Add sk_sp setters; .release() becomes std::move() (Closed)

Created:
4 years, 9 months ago by hal.canary
Modified:
4 years, 9 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkPDF: Add sk_sp setters; .release() becomes std::move() (patchset #2 id:20001 of https://codereview.chromium.org/1775043002/ ) Reason for revert: https://build.chromium.org/p/client.skia/builders/Linux%20Builder/builds/6405/steps/compile/logs/stdio Original issue's description: > SkPDF: Add sk_sp setters; .release() becomes std::move() > > Note to reviewers: Start with changes to SkPDFTypes.h > > Many places that had a bare pointer owning a reference are refactored to > use a sk_sp. > > There remain several places where a non-owning pointer `T*` should be > replaced with `const sk_sp<T>&` to eliminate the common pattern > `sk_sp<T>(SkRef(x))`. > > Committed: https://skia.googlesource.com/skia/+/9904c9212074279380e21f96575078734dbbd308 TBR=bungeman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/51d04d3c17954f9f8629e7d8a9fe870a7b19962f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -274 lines) Patch
M src/doc/SkDocument_PDF.cpp View 12 chunks +55 lines, -46 lines 0 comments Download
M src/pdf/SkPDFBitmap.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M src/pdf/SkPDFDevice.h View 2 chunks +12 lines, -8 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 6 chunks +34 lines, -32 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 17 chunks +46 lines, -46 lines 0 comments Download
M src/pdf/SkPDFFormXObject.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/pdf/SkPDFGraphicState.cpp View 3 chunks +7 lines, -12 lines 0 comments Download
M src/pdf/SkPDFResourceDict.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFResourceDict.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/pdf/SkPDFShader.cpp View 8 chunks +15 lines, -14 lines 0 comments Download
M src/pdf/SkPDFTypes.h View 8 chunks +26 lines, -13 lines 0 comments Download
M src/pdf/SkPDFTypes.cpp View 9 chunks +47 lines, -49 lines 0 comments Download
M src/pdf/SkPDFUtils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pdf/SkPDFUtils.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M tests/PDFPrimitivesTest.cpp View 14 chunks +30 lines, -30 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hal.canary
Created Revert of SkPDF: Add sk_sp setters; .release() becomes std::move()
4 years, 9 months ago (2016-03-08 21:03:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775143002/1
4 years, 9 months ago (2016-03-08 21:03:51 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 21:03:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/51d04d3c17954f9f8629e7d8a9fe870a7b19962f

Powered by Google App Engine
This is Rietveld 408576698