Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1775123003: [wasm] Encode immediates to Load and Store as varint. (Closed)

Created:
4 years, 9 months ago by titzer
Modified:
4 years, 9 months ago
Reviewers:
binji
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Encode immediates to Load and Store as varint. R=binji@chromium.org BUG= Committed: https://crrev.com/f99624a98efabb05dd2770327b47400a69093bc2 Cr-Commit-Position: refs/heads/master@{#34635}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -129 lines) Patch
M src/wasm/asm-wasm-builder.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/wasm/ast-decoder.h View 1 chunk +8 lines, -10 lines 0 comments Download
M src/wasm/encoder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/wasm/encoder.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/wasm/wasm-macro-gen.h View 1 2 chunks +7 lines, -6 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 2 chunks +0 lines, -23 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 3 chunks +10 lines, -6 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M test/mjsunit/wasm/module-memory.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/start-function.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/test-wasm-module-builder.js View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 7 chunks +43 lines, -67 lines 0 comments Download
M test/unittests/wasm/wasm-macro-gen-unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
titzer
4 years, 9 months ago (2016-03-09 17:58:22 UTC) #1
binji
lgtm, some nits, but not a big deal either way https://codereview.chromium.org/1775123003/diff/1/src/wasm/wasm-macro-gen.h File src/wasm/wasm-macro-gen.h (right): https://codereview.chromium.org/1775123003/diff/1/src/wasm/wasm-macro-gen.h#newcode339 ...
4 years, 9 months ago (2016-03-09 18:13:28 UTC) #2
titzer
https://codereview.chromium.org/1775123003/diff/1/src/wasm/wasm-macro-gen.h File src/wasm/wasm-macro-gen.h (right): https://codereview.chromium.org/1775123003/diff/1/src/wasm/wasm-macro-gen.h#newcode339 src/wasm/wasm-macro-gen.h:339: 0, static_cast<byte>(offset), index On 2016/03/09 18:13:28, binji wrote: > ...
4 years, 9 months ago (2016-03-09 18:49:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775123003/20001
4 years, 9 months ago (2016-03-09 18:49:31 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-09 18:51:36 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 18:54:55 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f99624a98efabb05dd2770327b47400a69093bc2
Cr-Commit-Position: refs/heads/master@{#34635}

Powered by Google App Engine
This is Rietveld 408576698