src/compiler/s390/instruction-selector-s390.cc - Issue 1775083002: [turbofan] Fix register constraint for memory barrier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/s390/instruction-selector-s390.cc

Issue 1775083002: [turbofan] Fix register constraint for memory barrier. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix other platforms, too Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/s390/instruction-selector-s390.cc

diff --git a/src/compiler/s390/instruction-selector-s390.cc b/src/compiler/s390/instruction-selector-s390.cc

index 179d88e85751a0c04e024a4138488ed5d3d8237e..ac2c07e16216a18a8d57e89c4e076a0baf5ded30 100644

--- a/src/compiler/s390/instruction-selector-s390.cc

+++ b/src/compiler/s390/instruction-selector-s390.cc

@@ -243,9 +243,7 @@ void InstructionSelector::VisitStore(Node* node) {

inputs[input_count++] = g.UseUniqueRegister(offset);

addressing_mode = kMode_MRR;

}

- inputs[input_count++] = (write_barrier_kind == kMapWriteBarrier)

- ? g.UseRegister(value)

- : g.UseUniqueRegister(value);

+ inputs[input_count++] = g.UseUniqueRegister(value);

RecordWriteMode record_write_mode = RecordWriteMode::kValueIsAny;

switch (write_barrier_kind) {

case kNoWriteBarrier: