Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: src/compiler/x87/instruction-selector-x87.cc

Issue 1775083002: [turbofan] Fix register constraint for memory barrier. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix other platforms, too Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/x64/instruction-selector-x64.cc ('k') | test/mjsunit/regress/regress-590074.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/compiler/instruction-selector-impl.h" 6 #include "src/compiler/instruction-selector-impl.h"
7 #include "src/compiler/node-matchers.h" 7 #include "src/compiler/node-matchers.h"
8 #include "src/compiler/node-properties.h" 8 #include "src/compiler/node-properties.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 InstructionOperand inputs[3]; 186 InstructionOperand inputs[3];
187 size_t input_count = 0; 187 size_t input_count = 0;
188 inputs[input_count++] = g.UseUniqueRegister(base); 188 inputs[input_count++] = g.UseUniqueRegister(base);
189 if (g.CanBeImmediate(index)) { 189 if (g.CanBeImmediate(index)) {
190 inputs[input_count++] = g.UseImmediate(index); 190 inputs[input_count++] = g.UseImmediate(index);
191 addressing_mode = kMode_MRI; 191 addressing_mode = kMode_MRI;
192 } else { 192 } else {
193 inputs[input_count++] = g.UseUniqueRegister(index); 193 inputs[input_count++] = g.UseUniqueRegister(index);
194 addressing_mode = kMode_MR1; 194 addressing_mode = kMode_MR1;
195 } 195 }
196 inputs[input_count++] = (write_barrier_kind == kMapWriteBarrier) 196 inputs[input_count++] = g.UseUniqueRegister(value);
197 ? g.UseRegister(value)
198 : g.UseUniqueRegister(value);
199 RecordWriteMode record_write_mode = RecordWriteMode::kValueIsAny; 197 RecordWriteMode record_write_mode = RecordWriteMode::kValueIsAny;
200 switch (write_barrier_kind) { 198 switch (write_barrier_kind) {
201 case kNoWriteBarrier: 199 case kNoWriteBarrier:
202 UNREACHABLE(); 200 UNREACHABLE();
203 break; 201 break;
204 case kMapWriteBarrier: 202 case kMapWriteBarrier:
205 record_write_mode = RecordWriteMode::kValueIsMap; 203 record_write_mode = RecordWriteMode::kValueIsMap;
206 break; 204 break;
207 case kPointerWriteBarrier: 205 case kPointerWriteBarrier:
208 record_write_mode = RecordWriteMode::kValueIsPointer; 206 record_write_mode = RecordWriteMode::kValueIsPointer;
(...skipping 1258 matching lines...) Expand 10 before | Expand all | Expand 10 after
1467 MachineOperatorBuilder::kFloat32RoundTruncate | 1465 MachineOperatorBuilder::kFloat32RoundTruncate |
1468 MachineOperatorBuilder::kFloat64RoundTruncate | 1466 MachineOperatorBuilder::kFloat64RoundTruncate |
1469 MachineOperatorBuilder::kFloat32RoundTiesEven | 1467 MachineOperatorBuilder::kFloat32RoundTiesEven |
1470 MachineOperatorBuilder::kFloat64RoundTiesEven; 1468 MachineOperatorBuilder::kFloat64RoundTiesEven;
1471 return flags; 1469 return flags;
1472 } 1470 }
1473 1471
1474 } // namespace compiler 1472 } // namespace compiler
1475 } // namespace internal 1473 } // namespace internal
1476 } // namespace v8 1474 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/x64/instruction-selector-x64.cc ('k') | test/mjsunit/regress/regress-590074.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698