Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/compiler/mips64/instruction-selector-mips64.cc

Issue 1775083002: [turbofan] Fix register constraint for memory barrier. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix other platforms, too Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/base/bits.h" 6 #include "src/base/bits.h"
7 #include "src/compiler/instruction-selector-impl.h" 7 #include "src/compiler/instruction-selector-impl.h"
8 #include "src/compiler/node-matchers.h" 8 #include "src/compiler/node-matchers.h"
9 #include "src/compiler/node-properties.h" 9 #include "src/compiler/node-properties.h"
10 10
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 WriteBarrierKind write_barrier_kind = store_rep.write_barrier_kind(); 194 WriteBarrierKind write_barrier_kind = store_rep.write_barrier_kind();
195 MachineRepresentation rep = store_rep.representation(); 195 MachineRepresentation rep = store_rep.representation();
196 196
197 // TODO(mips): I guess this could be done in a better way. 197 // TODO(mips): I guess this could be done in a better way.
198 if (write_barrier_kind != kNoWriteBarrier) { 198 if (write_barrier_kind != kNoWriteBarrier) {
199 DCHECK_EQ(MachineRepresentation::kTagged, rep); 199 DCHECK_EQ(MachineRepresentation::kTagged, rep);
200 InstructionOperand inputs[3]; 200 InstructionOperand inputs[3];
201 size_t input_count = 0; 201 size_t input_count = 0;
202 inputs[input_count++] = g.UseUniqueRegister(base); 202 inputs[input_count++] = g.UseUniqueRegister(base);
203 inputs[input_count++] = g.UseUniqueRegister(index); 203 inputs[input_count++] = g.UseUniqueRegister(index);
204 inputs[input_count++] = (write_barrier_kind == kMapWriteBarrier) 204 inputs[input_count++] = g.UseUniqueRegister(value);
205 ? g.UseRegister(value)
206 : g.UseUniqueRegister(value);
207 RecordWriteMode record_write_mode = RecordWriteMode::kValueIsAny; 205 RecordWriteMode record_write_mode = RecordWriteMode::kValueIsAny;
208 switch (write_barrier_kind) { 206 switch (write_barrier_kind) {
209 case kNoWriteBarrier: 207 case kNoWriteBarrier:
210 UNREACHABLE(); 208 UNREACHABLE();
211 break; 209 break;
212 case kMapWriteBarrier: 210 case kMapWriteBarrier:
213 record_write_mode = RecordWriteMode::kValueIsMap; 211 record_write_mode = RecordWriteMode::kValueIsMap;
214 break; 212 break;
215 case kPointerWriteBarrier: 213 case kPointerWriteBarrier:
216 record_write_mode = RecordWriteMode::kValueIsPointer; 214 record_write_mode = RecordWriteMode::kValueIsPointer;
(...skipping 1719 matching lines...) Expand 10 before | Expand all | Expand 10 after
1936 MachineOperatorBuilder::kFloat32RoundUp | 1934 MachineOperatorBuilder::kFloat32RoundUp |
1937 MachineOperatorBuilder::kFloat64RoundTruncate | 1935 MachineOperatorBuilder::kFloat64RoundTruncate |
1938 MachineOperatorBuilder::kFloat32RoundTruncate | 1936 MachineOperatorBuilder::kFloat32RoundTruncate |
1939 MachineOperatorBuilder::kFloat64RoundTiesEven | 1937 MachineOperatorBuilder::kFloat64RoundTiesEven |
1940 MachineOperatorBuilder::kFloat32RoundTiesEven; 1938 MachineOperatorBuilder::kFloat32RoundTiesEven;
1941 } 1939 }
1942 1940
1943 } // namespace compiler 1941 } // namespace compiler
1944 } // namespace internal 1942 } // namespace internal
1945 } // namespace v8 1943 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/mips/instruction-selector-mips.cc ('k') | src/compiler/ppc/instruction-selector-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698