Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: src/compiler/ia32/instruction-selector-ia32.cc

Issue 1775083002: [turbofan] Fix register constraint for memory barrier. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix other platforms, too Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/compiler/instruction-selector-impl.h" 6 #include "src/compiler/instruction-selector-impl.h"
7 #include "src/compiler/node-matchers.h" 7 #include "src/compiler/node-matchers.h"
8 #include "src/compiler/node-properties.h" 8 #include "src/compiler/node-properties.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 InstructionOperand inputs[3]; 225 InstructionOperand inputs[3];
226 size_t input_count = 0; 226 size_t input_count = 0;
227 inputs[input_count++] = g.UseUniqueRegister(base); 227 inputs[input_count++] = g.UseUniqueRegister(base);
228 if (g.CanBeImmediate(index)) { 228 if (g.CanBeImmediate(index)) {
229 inputs[input_count++] = g.UseImmediate(index); 229 inputs[input_count++] = g.UseImmediate(index);
230 addressing_mode = kMode_MRI; 230 addressing_mode = kMode_MRI;
231 } else { 231 } else {
232 inputs[input_count++] = g.UseUniqueRegister(index); 232 inputs[input_count++] = g.UseUniqueRegister(index);
233 addressing_mode = kMode_MR1; 233 addressing_mode = kMode_MR1;
234 } 234 }
235 inputs[input_count++] = (write_barrier_kind == kMapWriteBarrier) 235 inputs[input_count++] = g.UseUniqueRegister(value);
236 ? g.UseRegister(value)
237 : g.UseUniqueRegister(value);
238 RecordWriteMode record_write_mode = RecordWriteMode::kValueIsAny; 236 RecordWriteMode record_write_mode = RecordWriteMode::kValueIsAny;
239 switch (write_barrier_kind) { 237 switch (write_barrier_kind) {
240 case kNoWriteBarrier: 238 case kNoWriteBarrier:
241 UNREACHABLE(); 239 UNREACHABLE();
242 break; 240 break;
243 case kMapWriteBarrier: 241 case kMapWriteBarrier:
244 record_write_mode = RecordWriteMode::kValueIsMap; 242 record_write_mode = RecordWriteMode::kValueIsMap;
245 break; 243 break;
246 case kPointerWriteBarrier: 244 case kPointerWriteBarrier:
247 record_write_mode = RecordWriteMode::kValueIsPointer; 245 record_write_mode = RecordWriteMode::kValueIsPointer;
(...skipping 1217 matching lines...) Expand 10 before | Expand all | Expand 10 after
1465 MachineOperatorBuilder::kFloat64RoundTruncate | 1463 MachineOperatorBuilder::kFloat64RoundTruncate |
1466 MachineOperatorBuilder::kFloat32RoundTiesEven | 1464 MachineOperatorBuilder::kFloat32RoundTiesEven |
1467 MachineOperatorBuilder::kFloat64RoundTiesEven; 1465 MachineOperatorBuilder::kFloat64RoundTiesEven;
1468 } 1466 }
1469 return flags; 1467 return flags;
1470 } 1468 }
1471 1469
1472 } // namespace compiler 1470 } // namespace compiler
1473 } // namespace internal 1471 } // namespace internal
1474 } // namespace v8 1472 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/arm64/instruction-selector-arm64.cc ('k') | src/compiler/mips/instruction-selector-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698