Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 1775073002: Add isolate_win_toolchain.py (Closed)

Created:
4 years, 9 months ago by borenet2
Modified:
4 years, 9 months ago
Reviewers:
kjlubick, stephana, borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add isolate_win_toolchain.py Intended to be run manually by a developer on Windows. Downloads the requested Windows toolchain, uploads it to the isolate server, records the isolated hash in the JSON file and uploads a CL to update that file. BUG=skia:4553, skia:4763 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1775073002 Committed: https://skia.googlesource.com/skia/+/2bcfb4bec33efc0d113dc7d21830dd69f6b83ad0

Patch Set 1 #

Patch Set 2 : .bat #

Patch Set 3 : Write .gclient #

Patch Set 4 : Comment out rmtree temporarily #

Patch Set 5 : ... #

Patch Set 6 : Fixes #

Patch Set 7 : Add --isolate #

Patch Set 8 : nohooks #

Patch Set 9 : Fix isolate file path #

Patch Set 10 : Fix (?) iolate #

Patch Set 11 : Fix toolchain dir? #

Patch Set 12 : ... #

Patch Set 13 : ... #

Patch Set 14 : json #

Patch Set 15 : add json file #

Patch Set 16 : Fix param order #

Patch Set 17 : Fix toolchain version #

Patch Set 18 : Add hashes #

Patch Set 19 : Ready for review #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -1 line) Patch
A infra/bots/isolate_win_toolchain.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +109 lines, -0 lines 2 comments Download
M infra/bots/utils.py View 1 2 3 4 5 2 chunks +177 lines, -0 lines 0 comments Download
A + infra/bots/win_toolchain.isolate View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
A infra/bots/win_toolchain_hash.json View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
borenet2
4 years, 9 months ago (2016-03-09 20:53:42 UTC) #4
kjlubick
lgtm
4 years, 9 months ago (2016-03-10 14:12:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775073002/360001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775073002/360001
4 years, 9 months ago (2016-03-10 14:48:08 UTC) #7
commit-bot: I haz the power
Committed patchset #19 (id:360001) as https://skia.googlesource.com/skia/+/2bcfb4bec33efc0d113dc7d21830dd69f6b83ad0
4 years, 9 months ago (2016-03-10 15:01:42 UTC) #9
stephana
lgtm with one comment https://codereview.chromium.org/1775073002/diff/360001/infra/bots/isolate_win_toolchain.py File infra/bots/isolate_win_toolchain.py (right): https://codereview.chromium.org/1775073002/diff/360001/infra/bots/isolate_win_toolchain.py#newcode1 infra/bots/isolate_win_toolchain.py:1: #!/usr/bin/env python Can you add ...
4 years, 9 months ago (2016-03-10 15:03:36 UTC) #10
borenet
4 years, 9 months ago (2016-03-10 21:07:09 UTC) #11
Message was sent while issue was closed.
https://codereview.chromium.org/1775073002/diff/360001/infra/bots/isolate_win...
File infra/bots/isolate_win_toolchain.py (right):

https://codereview.chromium.org/1775073002/diff/360001/infra/bots/isolate_win...
infra/bots/isolate_win_toolchain.py:1: #!/usr/bin/env python
On 2016/03/10 15:03:36, stephana wrote:
> Can you add a short description of what the script does ?
> 

Done in https://codereview.chromium.org/1782943002/

Powered by Google App Engine
This is Rietveld 408576698