src/pdf/SkPDFUtils.h - Issue 1775043002: SkPDF: Add sk_sp setters; .release() becomes std::move()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFUtils.h

Issue 1775043002: SkPDF: Add sk_sp setters; .release() becomes std::move() (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fix -Wpessimizing-move Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFUtils.h

diff --git a/src/pdf/SkPDFUtils.h b/src/pdf/SkPDFUtils.h

index 814d77193cb38d5bd803f847cf36a5e6ab2d1603..0dec80077c8c00c30c242930b771c3444f22260b 100644

--- a/src/pdf/SkPDFUtils.h

+++ b/src/pdf/SkPDFUtils.h

@@ -35,8 +35,8 @@ class SkWStream;

class SkPDFUtils {

public:

- static SkPDFArray* RectToArray(const SkRect& rect);

- static SkPDFArray* MatrixToArray(const SkMatrix& matrix);

+ static sk_sp<SkPDFArray> RectToArray(const SkRect& rect);

+ static sk_sp<SkPDFArray> MatrixToArray(const SkMatrix& matrix);

static void AppendTransform(const SkMatrix& matrix, SkWStream* content);

static void MoveTo(SkScalar x, SkScalar y, SkWStream* content);

« no previous file with comments | « src/pdf/SkPDFTypes.cpp ('k') | src/pdf/SkPDFUtils.cpp » ('j') | no next file with comments »