src/pdf/SkPDFResourceDict.h - Issue 1775043002: SkPDF: Add sk_sp setters; .release() becomes std::move()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFResourceDict.h

Issue 1775043002: SkPDF: Add sk_sp setters; .release() becomes std::move() (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fix -Wpessimizing-move Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFResourceDict.h

diff --git a/src/pdf/SkPDFResourceDict.h b/src/pdf/SkPDFResourceDict.h

index 698823b36ceda8c10bc0fdf14e7c4c6bf1345a5c..c45b364adc896fdf5ed4dfbcbf8a3c0b9c9d9831 100644

--- a/src/pdf/SkPDFResourceDict.h

+++ b/src/pdf/SkPDFResourceDict.h

@@ -36,7 +36,7 @@ public:

* Any arguments can be nullptr.

- static SkPDFDict* Create(

+ static sk_sp<SkPDFDict> Make(

const SkTDArray<SkPDFObject*>* gStateResources,

const SkTDArray<SkPDFObject*>* patternResources,

const SkTDArray<SkPDFObject*>* xObjectResources,

« no previous file with comments | « src/pdf/SkPDFGraphicState.cpp ('k') | src/pdf/SkPDFResourceDict.cpp » ('j') | no next file with comments »