Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1775023003: Re-land "Split CPDF_SyntaxParser into its own named .cpp/.h files." (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Re-land "Split CPDF_SyntaxParser into its own named .cpp/.h files." This reverts commit 06fae28d307fe051f0c7e890344cd487c2260910. R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/b70f5a44635d29981abac766d727ff54daea2c37

Patch Set 1 : Original failed patch #

Patch Set 2 : Include <vector>. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1231 lines, -1175 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 5 chunks +4 lines, -82 lines 0 comments Download
A core/src/fpdfapi/fpdf_parser/cpdf_syntax_parser.h View 1 chunk +96 lines, -0 lines 0 comments Download
A core/src/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp View 1 1 chunk +978 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 34 chunks +145 lines, -1091 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M pdfium.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Sepez
Dan, try #2. Thanks.
4 years, 9 months ago (2016-03-08 20:33:31 UTC) #3
dsinclair
lgtm
4 years, 9 months ago (2016-03-08 20:34:18 UTC) #4
Tom Sepez
4 years, 9 months ago (2016-03-08 20:42:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b70f5a44635d29981abac766d727ff54daea2c37 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698