Enterprise policy to prevent queries to the Quirks Server

components/policy/resources/policy_templates.json

Index: components/policy/resources/policy_templates.json
diff --git a/components/policy/resources/policy_templates.json b/components/policy/resources/policy_templates.json
index a628c92e51fca1210f40ab12fc49d0f9d0a2b8c1..1d400247941cc79531503334bf5f2fcec7188b35 100644
--- a/components/policy/resources/policy_templates.json
+++ b/components/policy/resources/policy_templates.json
@@ -137,7 +137,7 @@
 #   persistent IDs for all fields (but not for groups!) are needed. These are
 #   specified by the 'id' keys of each policy. NEVER CHANGE EXISTING IDs,
 #   because doing so would break the deployed wire format!
-#   For your editing convenience: highest ID currently used: 318
+#   For your editing convenience: highest ID currently used: 319
 #
 # Placeholders:
 #   The following placeholder strings are automatically substituted:
@@ -8220,7 +8220,31 @@
       solely to specify force-installation of the apps.
 
       If this policy is left not set, no apps are installed automatically.'''
-    }
+    },
+    {
+      'name': 'QuirksClientEnabled',

[Thiemo Nagel, 2016/03/08 20:07:58]

This should be a device policy, thus please prefix the name with "Device".  Also
I'd suggest to include "Display" in the name to make it easier to understand. 
Lastly I'd suggest to replace Client with Download (also to make it easier to
understand).

What would you think about DeviceDisplayQuirksDownloadEnabled?

[Greg Levin, 2016/03/14 17:29:47]

How about DeviceQuirksDownloadEnabled?  As noted in
https://bugs.chromium.org/p/chromium/issues/detail?id=567791#c15
while Quirks is currently only handling display profiles, we expect it could
eventually handle other hardware config files.

[Thiemo Nagel, 2016/03/23 14:53:23]

SGTM.

+      'type': 'main',
+      'schema': { 'type': 'boolean' },
+      'supported_on': ['chrome_os:51-'],
+      'features': {
+        'dynamic_refresh': True,

[Greg Levin, 2016/03/14 17:29:47]

http://www.chromium.org/developers/how-tos/enterprise/adding-new-policies says,
"Wherever possible, we would like to support dynamic policy refresh [...]
This means that you should listen for preference change notifications for your
preference."
My code does not listen for pref change notifications, but does check the pref
right before each download, in effect responding "dynamically" to policy
changes.  Is this sufficient to label this as True?

[Thiemo Nagel, 2016/03/23 14:53:23]

Absolutely.

+        'per_profile': False,

[Thiemo Nagel, 2016/03/08 20:07:58]

Please drop per_profile since it doesn't apply to device policy.

[Greg Levin, 2016/03/14 17:29:47]

Done, but...

+      },
+      'example_value': True,
+      'id': 319,
+      'default_for_enterprise_users': True,

[Thiemo Nagel, 2016/03/08 20:07:58]

This is only for cases where the enterprise default differs from the general
default.  Please drop.

[Greg Levin, 2016/03/14 17:29:47]

Done.

+      'caption': '''Enable queries to Quirks Server''',

[Thiemo Nagel, 2016/03/08 20:07:58]

Quirks --> Display Quirks

[Greg Levin, 2016/03/14 17:29:46]

Avoiding "display", but added a little more info.

+      'tags': [],
+      'desc':
+      '''When this policy is set to false, the device will not attempt to

[Thiemo Nagel, 2016/03/08 20:07:58]

I'd start out with one sentence explaining what display quirks is about and only
discuss the policy after that.

Is there any public documentation that you could refer to?  Contacting a Google
service always tends to raise eyebrows.  Please consider hosting (a copy of) the
design doc under chromium.org.

[Greg Levin, 2016/03/14 17:29:47]

Updated text.
I added a Question for this in the design doc (go/cros-quirks-client-dd), which
I'm sort of using as a TODO list.  We'll figure out what we want this to look
like, and I'll link to it from here when it's ready.

+      contact the Quirks Server to download display profile calibration data.
+      Downloaded data will be stored on the device, and improves display quality
+      of affected monitors.
+
+      If this policy is true or not configured then enterprise-enrolled devices
+      will automatically contact the Quirks Server and download display
+      calibration data, if available.''',
+    },
   ],
   'messages': {
     # Messages that are not associated to any policies.