Enterprise policy to prevent queries to the Quirks Server

components/policy/resources/policy_templates.json

 {
 # policy_templates.json - Metafile for policy templates
 #
 # The content of this file is evaluated as a Python expression.
 #
 # This file is used as input to generate the following policy templates:
 # ADM, ADMX+ADML, MCX/plist and html documentation.
 #
 # Policy templates are user interface definitions or documents about the
 # policies that can be used to configure Chrome. Each policy is a name-value
@@ skipping 119 matching lines @@
 #   templates and documentation. The policy definition list that Chrome sees
 #   will include policies marked with 'future'. If a WIP policy isn't meant to
 #   be seen by the policy providers either, the 'supported_on' key should be set
 #   to an empty list.
 #
 # IDs:
 #   Since a Protocol Buffer definition is generated from this file, unique and
 #   persistent IDs for all fields (but not for groups!) are needed. These are
 #   specified by the 'id' keys of each policy. NEVER CHANGE EXISTING IDs,
 #   because doing so would break the deployed wire format!
-#   For your editing convenience: highest ID currently used: 318
+#   For your editing convenience: highest ID currently used: 319
 #
 # Placeholders:
 #   The following placeholder strings are automatically substituted:
 #     $1 -> Google Chrome / Chromium
 #     $2 -> Google Chrome OS / Chromium OS
 #     $3 -> Google Chrome Frame / Chromium Frame
 #     $6 is reserved for doc_writer
 #
 # Device Policy:
 #   An additional flag 'device_only' (optional, defaults to False) indicates
@@ skipping 8062 matching lines @@
       'example_value': '',
       'id': 318,
       'caption': '''Configure ARC apps''',
       'tags': [],
       'desc':
       '''Specifies the ARC application policy as JSON string which can be
       handed-off as-is to the ARC runtime. At the moment, this setting is used
       solely to specify force-installation of the apps.
 
       If this policy is left not set, no apps are installed automatically.'''
-    }
+    },
+    {
+      'name': 'DeviceQuirksDownloadEnabled',
+      'type': 'main',
+      'schema': { 'type': 'boolean' },
+      'supported_on': ['chrome_os:51-'],
+      'features': {
+        'dynamic_refresh': True,
+      },

[Greg Levin, 2016/03/14 17:29:47]

... when I removed 'per_profile', the presubmit check complained:

In features DeviceQuirksDownloadEnabled: Error: Features must have a bool
"per_profile".
  Offending: {
  "dynamic_refresh": true
}
Finished checking
/ssd/chrome/src/components/policy/resources/policy_templates.json. 1 errors, 0
warnings.

How can I remove this error without simply bypassing hooks?

[Thiemo Nagel, 2016/03/23 14:53:24]

I think once you add "'device_only': True" after supported_on... the presubmit
shouldn't complain about missing per_profile anymore.

[Greg Levin, 2016/03/24 23:21:39]

Done.

+      'example_value': True,
+      'id': 319,
+      'caption': '''Enable queries to Quirks Server for hardware profiles''',
+      'tags': [],
+      'desc':
+      '''The Quirks Server provides hardware-specific configuration files, like
+      icc display profiles to adjust monitor calibration.
+
+      When this policy is set to false, the device will not attempt to
+      contact the Quirks Server to download configuration files.
+
+      If this policy is true or not configured then enterprise-enrolled devices
+      will automatically contact the Quirks Server and download configuration
+      files, if available, and store them on the device.  Such files might, for
+      example, be used to improve display quality of attached monitors.''',
+    },
   ],
   'messages': {
     # Messages that are not associated to any policies.
     'win_supported_winxpsp2': {
       'desc': '''A label specifying the oldest possible compatible version of Windows. This text will appear right next to a label containing the text 'Supported on:'.''',
       'text': '''Microsoft Windows XP SP2 or later'''
     },
     'mac_chrome_preferences': {
       'desc': '''A text indicating in Mac OS X Workgroup Manager, that currently the preferences of Chromium are being edited''',
       'text': '''<ph name="PRODUCT_NAME">$1<ex>Google Chrome</ex></ph> preferences'''
@@ skipping 109 matching lines @@
       'desc': '''Text appended in parentheses next to the policies top-level container to indicate that those policies are of the Recommended level''',
       'text': 'Default Settings (users can override)',
     },
     'doc_complex_policies_on_windows': {
       'desc': '''Text pointing the user to a help article for complex policies on Windows''',
       'text': '''encoded as a JSON string, for details see <ph name="COMPLEX_POLICIES_URL">https://www.chromium.org/administrators/complex-policies-on-windows<ex>https://www.chromium.org/administrators/complex-policies-on-windows</ex></ph>''',
     },
   },
   'placeholders': [],
 }