Enterprise policy to prevent queries to the Quirks Server

components/policy/resources/policy_templates.json

 {
 # policy_templates.json - Metafile for policy templates
 #
 # The content of this file is evaluated as a Python expression.
 #
 # This file is used as input to generate the following policy templates:
 # ADM, ADMX+ADML, MCX/plist and html documentation.
 #
 # Policy templates are user interface definitions or documents about the
 # policies that can be used to configure Chrome. Each policy is a name-value
@@ skipping 119 matching lines @@
 #   templates and documentation. The policy definition list that Chrome sees
 #   will include policies marked with 'future'. If a WIP policy isn't meant to
 #   be seen by the policy providers either, the 'supported_on' key should be set
 #   to an empty list.
 #
 # IDs:
 #   Since a Protocol Buffer definition is generated from this file, unique and
 #   persistent IDs for all fields (but not for groups!) are needed. These are
 #   specified by the 'id' keys of each policy. NEVER CHANGE EXISTING IDs,
 #   because doing so would break the deployed wire format!
-#   For your editing convenience: highest ID currently used: 318
+#   For your editing convenience: highest ID currently used: 319
 #
 # Placeholders:
 #   The following placeholder strings are automatically substituted:
 #     $1 -> Google Chrome / Chromium
 #     $2 -> Google Chrome OS / Chromium OS
 #     $3 -> Google Chrome Frame / Chromium Frame
 #     $6 is reserved for doc_writer
 #
 # Device Policy:
 #   An additional flag 'device_only' (optional, defaults to False) indicates
@@ skipping 8062 matching lines @@
       'example_value': '',
       'id': 318,
       'caption': '''Configure ARC apps''',
       'tags': [],
       'desc':
       '''Specifies the ARC application policy as JSON string which can be
       handed-off as-is to the ARC runtime. At the moment, this setting is used
       solely to specify force-installation of the apps.
 
       If this policy is left not set, no apps are installed automatically.'''
-    }
+    },
+    {
+      'name': 'QuirksClientEnabled',

[Thiemo Nagel, 2016/03/08 20:07:58]

This should be a device policy, thus please prefix the name with "Device".  Also
I'd suggest to include "Display" in the name to make it easier to understand. 
Lastly I'd suggest to replace Client with Download (also to make it easier to
understand).

What would you think about DeviceDisplayQuirksDownloadEnabled?

[Greg Levin, 2016/03/14 17:29:47]

How about DeviceQuirksDownloadEnabled?  As noted in
https://bugs.chromium.org/p/chromium/issues/detail?id=567791#c15
while Quirks is currently only handling display profiles, we expect it could
eventually handle other hardware config files.

[Thiemo Nagel, 2016/03/23 14:53:23]

SGTM.

+      'type': 'main',
+      'schema': { 'type': 'boolean' },
+      'supported_on': ['chrome_os:51-'],
+      'features': {
+        'dynamic_refresh': True,

[Greg Levin, 2016/03/14 17:29:47]

http://www.chromium.org/developers/how-tos/enterprise/adding-new-policies says,
"Wherever possible, we would like to support dynamic policy refresh [...]
This means that you should listen for preference change notifications for your
preference."
My code does not listen for pref change notifications, but does check the pref
right before each download, in effect responding "dynamically" to policy
changes.  Is this sufficient to label this as True?

[Thiemo Nagel, 2016/03/23 14:53:23]

Absolutely.

+        'per_profile': False,

[Thiemo Nagel, 2016/03/08 20:07:58]

Please drop per_profile since it doesn't apply to device policy.

[Greg Levin, 2016/03/14 17:29:47]

Done, but...

+      },
+      'example_value': True,
+      'id': 319,
+      'default_for_enterprise_users': True,

[Thiemo Nagel, 2016/03/08 20:07:58]

This is only for cases where the enterprise default differs from the general
default.  Please drop.

[Greg Levin, 2016/03/14 17:29:47]

Done.

+      'caption': '''Enable queries to Quirks Server''',

[Thiemo Nagel, 2016/03/08 20:07:58]

Quirks --> Display Quirks

[Greg Levin, 2016/03/14 17:29:46]

Avoiding "display", but added a little more info.

+      'tags': [],
+      'desc':
+      '''When this policy is set to false, the device will not attempt to

[Thiemo Nagel, 2016/03/08 20:07:58]

I'd start out with one sentence explaining what display quirks is about and only
discuss the policy after that.

Is there any public documentation that you could refer to?  Contacting a Google
service always tends to raise eyebrows.  Please consider hosting (a copy of) the
design doc under chromium.org.

[Greg Levin, 2016/03/14 17:29:47]

Updated text.
I added a Question for this in the design doc (go/cros-quirks-client-dd), which
I'm sort of using as a TODO list.  We'll figure out what we want this to look
like, and I'll link to it from here when it's ready.

+      contact the Quirks Server to download display profile calibration data.
+      Downloaded data will be stored on the device, and improves display quality
+      of affected monitors.
+
+      If this policy is true or not configured then enterprise-enrolled devices
+      will automatically contact the Quirks Server and download display
+      calibration data, if available.''',
+    },
   ],
   'messages': {
     # Messages that are not associated to any policies.
     'win_supported_winxpsp2': {
       'desc': '''A label specifying the oldest possible compatible version of Windows. This text will appear right next to a label containing the text 'Supported on:'.''',
       'text': '''Microsoft Windows XP SP2 or later'''
     },
     'mac_chrome_preferences': {
       'desc': '''A text indicating in Mac OS X Workgroup Manager, that currently the preferences of Chromium are being edited''',
       'text': '''<ph name="PRODUCT_NAME">$1<ex>Google Chrome</ex></ph> preferences'''
@@ skipping 109 matching lines @@
       'desc': '''Text appended in parentheses next to the policies top-level container to indicate that those policies are of the Recommended level''',
       'text': 'Default Settings (users can override)',
     },
     'doc_complex_policies_on_windows': {
       'desc': '''Text pointing the user to a help article for complex policies on Windows''',
       'text': '''encoded as a JSON string, for details see <ph name="COMPLEX_POLICIES_URL">https://www.chromium.org/administrators/complex-policies-on-windows<ex>https://www.chromium.org/administrators/complex-policies-on-windows</ex></ph>''',
     },
   },
   'placeholders': [],
 }