Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1775013005: Revert "Revert of Switch back to open image in new tab where applicable. (patchset #4 id:60001 of h… (Closed)

Created:
4 years, 9 months ago by Ted C
Modified:
4 years, 9 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Revert of Switch back to open image in new tab where applicable. (patchset #4 id:60001 of https://codereview.chromium.org/1741153002/ )" This reverts commit aea0d270c480410ad8764473797bbf5b5f6c6189. BUG=593316 Committed: https://crrev.com/42e21a0e7325f5f06626a494bd2710913195863b Cr-Commit-Position: refs/heads/master@{#380193}

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Fix oversight #

Messages

Total messages: 8 (3 generated)
Ted C
PTAL Base patch is the pure revert. Delta to patch 3 is the test fix ...
4 years, 9 months ago (2016-03-09 18:53:43 UTC) #2
newt (away)
lgtm
4 years, 9 months ago (2016-03-09 18:59:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775013005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775013005/40001
4 years, 9 months ago (2016-03-09 19:03:05 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-09 20:10:25 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 20:12:37 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/42e21a0e7325f5f06626a494bd2710913195863b
Cr-Commit-Position: refs/heads/master@{#380193}

Powered by Google App Engine
This is Rietveld 408576698