Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp

Issue 1775013003: Implement -webkit-box-reflect as a filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make msvc dbg happy Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp b/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp
index 4724206d5d40f61fc02fb59c446b0d8d7a7fb7da..150b48bb0ca0790c687361e2d00989a9dc20a50b 100644
--- a/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp
+++ b/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp
@@ -34,6 +34,8 @@
#include "platform/graphics/filters/FilterOperations.h"
#include "platform/graphics/filters/SourceGraphic.h"
#include "platform/graphics/skia/SkiaUtils.h"
+#include "third_party/skia/include/core/SkXfermode.h"
+#include "third_party/skia/include/effects/SkXfermodeImageFilter.h"
namespace blink {
@@ -160,6 +162,15 @@ void SkiaImageFilterBuilder::buildFilterOperations(const FilterOperations& opera
filters->appendDropShadowFilter(drop.location(), drop.stdDeviation(), drop.getColor());
break;
}
+ case FilterOperation::BOX_REFLECT: {
+ // TODO(jbroman): Consider explaining box reflect to the compositor,
+ // instead of calling this a "reference filter".
+ const auto& reflectOperation = toBoxReflectFilterOperation(op);
+ RefPtr<SkImageFilter> imageFilter = buildBoxReflectFilter(
+ reflectOperation.direction(), reflectOperation.offset(), nullptr, nullFilter);
+ filters->appendReferenceFilter(imageFilter.get());
+ break;
+ }
case FilterOperation::NONE:
break;
}
@@ -176,4 +187,40 @@ PassRefPtr<SkImageFilter> SkiaImageFilterBuilder::buildTransform(const AffineTra
return adoptRef(SkImageFilter::CreateMatrixFilter(affineTransformToSkMatrix(transform), kHigh_SkFilterQuality, input));
}
+SkMatrix SkiaImageFilterBuilder::matrixForBoxReflectFilter(ReflectionDirection direction, float offset)
+{
+ SkMatrix flipMatrix;
+ switch (direction) {
+ case VerticalReflection:
+ flipMatrix.setScale(1, -1);
+ flipMatrix.postTranslate(0, offset);
+ break;
+ case HorizontalReflection:
+ flipMatrix.setScale(-1, 1);
+ flipMatrix.postTranslate(offset, 0);
+ break;
+ default:
+ // MSVC requires that SkMatrix be initialized in this unreachable case.
+ NOTREACHED();
+ flipMatrix.reset();
+ break;
+ }
+ return flipMatrix;
+}
+
+PassRefPtr<SkImageFilter> SkiaImageFilterBuilder::buildBoxReflectFilter(ReflectionDirection direction, float offset, Image* maskImage, SkImageFilter* input)
+{
+ RefPtr<SkImageFilter> maskedInput = input;
+ // TODO(jbroman): If a mask image is provided, mask!
+
+ SkMatrix flipMatrix = matrixForBoxReflectFilter(direction, offset);
+ RefPtr<SkImageFilter> flipImageFilter = adoptRef(SkImageFilter::CreateMatrixFilter(
+ flipMatrix, kNone_SkFilterQuality, maskedInput.get()));
+
+ RefPtr<SkImageFilter> combineImageFilter = adoptRef(SkXfermodeImageFilter::Create(
+ nullptr, flipImageFilter.get(), input));
+
+ return combineImageFilter.release();
+}
+
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698