Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FilterOperations.cpp

Issue 1775013003: Implement -webkit-box-reflect as a filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make msvc dbg happy Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/filters/FilterOperations.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/filters/FilterOperations.cpp b/third_party/WebKit/Source/platform/graphics/filters/FilterOperations.cpp
index e1db93e02c09374d4d28f361a044be76435c7f56..093ddf931b64863739cf33d5023ece1764267e5d 100644
--- a/third_party/WebKit/Source/platform/graphics/filters/FilterOperations.cpp
+++ b/third_party/WebKit/Source/platform/graphics/filters/FilterOperations.cpp
@@ -105,7 +105,10 @@ bool FilterOperations::hasOutsets() const
{
for (size_t i = 0; i < m_operations.size(); ++i) {
FilterOperation::OperationType operationType = m_operations.at(i)->type();
- if (operationType == FilterOperation::BLUR || operationType == FilterOperation::DROP_SHADOW || operationType == FilterOperation::REFERENCE)
+ if (operationType == FilterOperation::BLUR
+ || operationType == FilterOperation::DROP_SHADOW
+ || operationType == FilterOperation::REFERENCE
+ || operationType == FilterOperation::BOX_REFLECT)
return true;
}
return false;
@@ -152,6 +155,10 @@ FilterOutsets FilterOperations::outsets() const
}
break;
}
+ case FilterOperation::BOX_REFLECT: {
+ // Already accounted for at all call sites.
+ break;
+ }
default:
break;
}
@@ -176,4 +183,3 @@ bool FilterOperations::hasFilterThatMovesPixels() const
}
} // namespace blink
-

Powered by Google App Engine
This is Rietveld 408576698