Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 1775013003: Implement -webkit-box-reflect as a filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make msvc dbg happy Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h
index a9f806655304502660e529e138e4909dc25756c3..aa2fafa8ffded3387cf2d7f7c762d47b36c4e9b6 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h
@@ -460,7 +460,10 @@ public:
return imageOutsets(borderImage());
}
- bool hasFilterOutsets() const { return hasFilter() && filter().hasOutsets(); }
+ // Returns |true| if any property that renders using filter operations is
+ // used (including, but not limited to, 'filter').
+ bool hasFilterInducingProperty() const { return hasFilter() || (RuntimeEnabledFeatures::cssBoxReflectFilterEnabled() && hasBoxReflect()); }
+
Order rtlOrdering() const { return static_cast<Order>(inherited_flags.m_rtlOrdering); }
void setRTLOrdering(Order o) { inherited_flags.m_rtlOrdering = o; }
@@ -847,6 +850,7 @@ public:
EBoxDecorationBreak boxDecorationBreak() const { return m_box->boxDecorationBreak(); }
StyleReflection* boxReflect() const { return rareNonInheritedData->m_boxReflect.get(); }
+ bool hasBoxReflect() const { return boxReflect(); }
bool reflectionDataEquivalent(const ComputedStyle* otherStyle) const { return rareNonInheritedData->reflectionDataEquivalent(*otherStyle->rareNonInheritedData); }
// FIXME: reflections should belong to this helper function but they are currently handled
@@ -1641,7 +1645,17 @@ public:
bool hasChildDependentFlags() const { return emptyState() || hasExplicitlyInheritedProperties(); }
void copyChildDependentFlagsFrom(const ComputedStyle&);
- bool hasBoxDecorations() const { return hasBorderDecoration() || hasBorderRadius() || hasOutline() || hasAppearance() || boxShadow() || hasFilter() || hasBackdropFilter() || resize() != RESIZE_NONE; }
+ bool hasBoxDecorations() const
+ {
+ return hasBorderDecoration()
+ || hasBorderRadius()
+ || hasOutline()
+ || hasAppearance()
+ || boxShadow()
+ || hasFilterInducingProperty()
+ || hasBackdropFilter()
+ || resize() != RESIZE_NONE;
+ }
bool borderObscuresBackground() const;
void getBorderEdgeInfo(BorderEdge edges[], bool includeLogicalLeftEdge = true, bool includeLogicalRightEdge = true) const;
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp ('k') | third_party/WebKit/Source/core/style/ComputedStyle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698