third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp - Issue 1775013003: Implement -webkit-box-reflect as a filter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

Issue 1775013003: Implement -webkit-box-reflect as a filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make msvc dbg happy Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp ('k') | third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

index d51d98fbb28c8b9f99f516629eb9d6e339d30261..742fb6eff1f68a9e3ac0857c11d19fc081c3d53d 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

@@ -103,12 +103,12 @@ CompositingReasons CompositingReasonFinder::potentialCompositingReasonsFromStyle

reasons |= CompositingReasonCompositorProxy;

// If the implementation of createsGroup changes, we need to be aware of that in this part of code.

- ASSERT((layoutObject->isTransparent() || layoutObject->hasMask() || layoutObject->hasFilter() || style.hasBlendMode()) == layoutObject->createsGroup());

+ ASSERT((layoutObject->isTransparent() || layoutObject->hasMask() || layoutObject->hasFilterInducingProperty() || style.hasBlendMode()) == layoutObject->createsGroup());

if (style.hasMask())

reasons |= CompositingReasonMaskWithCompositedDescendants;

- if (style.hasFilter())

+ if (style.hasFilterInducingProperty())

reasons |= CompositingReasonFilterWithCompositedDescendants;

if (style.hasBackdropFilter())