Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2517)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 1775013003: Implement -webkit-box-reflect as a filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase master Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObject.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h b/third_party/WebKit/Source/core/layout/LayoutObject.h
index 92f100e0d222578fdcf01c60a1daf75fd5502ee1..47b2e1c1bf113e8f4ed0f39c9bf7bfde5ab0ab68 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.h
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.h
@@ -720,6 +720,10 @@ public:
bool hasFilter() const { return style() && style()->hasFilter(); }
pdr. 2016/03/29 18:36:55 Would it be cleaner to update paintInvalidationSta
bool hasBackdropFilter() const { return style() && style()->hasBackdropFilter(); }
+ bool hasFilterInducingProperty() const
Stephen White 2016/03/30 14:41:35 I find this name unintuitive. Could we be more exp
+ {
+ return (style() && style()->hasFilter()) || (RuntimeEnabledFeatures::cssBoxReflectFilterEnabled() && hasReflection());
+ }
bool hasShapeOutside() const { return style() && style()->shapeOutside(); }
@@ -1264,7 +1268,7 @@ public:
bool shouldUseTransformFromContainer(const LayoutObject* container) const;
void getTransformFromContainer(const LayoutObject* container, const LayoutSize& offsetInContainer, TransformationMatrix&) const;
- bool createsGroup() const { return isTransparent() || hasMask() || hasFilter() || style()->hasBlendMode(); }
+ bool createsGroup() const { return isTransparent() || hasMask() || hasFilterInducingProperty() || style()->hasBlendMode(); }
// Collects rectangles that the outline of this object would be drawing along the outside of,
// even if the object isn't styled with a outline for now. The rects also cover continuations.

Powered by Google App Engine
This is Rietveld 408576698