Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1774973004: Fetching the matching rules when control app is installed (Closed)

Created:
4 years, 9 months ago by Raj
Modified:
4 years, 9 months ago
Reviewers:
tbansal1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fetching the matching rules when control app is installed Matching rules are fetched on every UI navigation after the control app is installed. In addition to that rules should be fetched when control app gets installed as well. BUG=593143 Committed: https://crrev.com/8493756f1647a3f6a0e09d8b75c4c643d7b1ba2b Cr-Commit-Position: refs/heads/master@{#380002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -13 lines) Patch
M chrome/browser/android/data_usage/data_use_tab_model.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/android/data_usage/external_data_use_observer_unittest.cc View 3 chunks +19 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Raj
ptal
4 years, 9 months ago (2016-03-08 22:06:06 UTC) #2
tbansal1
lgtm
4 years, 9 months ago (2016-03-09 00:22:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774973004/1
4 years, 9 months ago (2016-03-09 00:50:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 00:55:49 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 00:57:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8493756f1647a3f6a0e09d8b75c4c643d7b1ba2b
Cr-Commit-Position: refs/heads/master@{#380002}

Powered by Google App Engine
This is Rietveld 408576698