Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1774973002: Revert of Update WindowTree::OnWindowInputEventAck to include handled (Closed)

Created:
4 years, 9 months ago by jonross
Modified:
4 years, 9 months ago
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update WindowTree::OnWindowInputEventAck to include handled (patchset #4 id:60001 of https://codereview.chromium.org/1749323002/ ) Reason for revert: This broke the Windows component build. https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/builds/4025 Original issue's description: > Update WindowTree::OnWindowInputEventAck to include handled > > To support post-target accelerators we plan to have the client application report whether an input event was handled or not, when ack-ing the event. > > This change updates WindowTree::OnWindowInputEventAck to include a boolean parameter |handled|. > > PlatformWindowMus will always mark events as handled. CompositorMusConnection will base the handled state on the ack state of the renderer. > > TEST=WindowTreeClientImplTest, WindowTreeApptest, WindowTreeTest, CompositorMusConnectionTest > BUG=560478 > > Committed: https://crrev.com/c3385cc179280dd4b09733b2954be7e9ae3b5112 > Cr-Commit-Position: refs/heads/master@{#379821} TBR=sky@chromium.org,tdresser@chromium.org,ben@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=560478 Committed: https://crrev.com/ce1b6c89699ef3d9b0834c0d840c2de0205517a4 Cr-Commit-Position: refs/heads/master@{#379830}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -558 lines) Patch
M components/mus/public/cpp/input_event_handler.h View 1 chunk +5 lines, -8 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 1 chunk +8 lines, -12 lines 0 comments Download
M components/mus/public/cpp/tests/test_window_tree.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/tests/test_window_tree.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/tests/window_tree_client_impl_unittest.cc View 3 chunks +7 lines, -14 lines 0 comments Download
M components/mus/public/interfaces/window_tree.mojom View 2 chunks +3 lines, -4 lines 0 comments Download
M components/mus/ws/window_tree.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_handler_manager.h View 2 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/input/render_widget_input_handler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection.h View 2 chunks +5 lines, -8 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection.cc View 4 chunks +6 lines, -15 lines 0 comments Download
D content/renderer/mus/compositor_mus_connection_unittest.cc View 1 chunk +0 lines, -466 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/mus/platform_window_mus.h View 1 chunk +3 lines, -4 lines 0 comments Download
M ui/views/mus/platform_window_mus.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jonross
Created Revert of Update WindowTree::OnWindowInputEventAck to include handled
4 years, 9 months ago (2016-03-08 15:07:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774973002/1
4 years, 9 months ago (2016-03-08 15:07:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 15:08:48 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 15:10:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce1b6c89699ef3d9b0834c0d840c2de0205517a4
Cr-Commit-Position: refs/heads/master@{#379830}

Powered by Google App Engine
This is Rietveld 408576698