Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1774953003: [heap] Add two tiny free list categories. (Closed)

Created:
4 years, 9 months ago by Hannes Payer (out of office)
Modified:
4 years, 9 months ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Add two tiny free list categories. This CL allows the sweeper to free up all memory >= free list item size (3 words). This may reduce memory consumption (especially in map space), but may be worse for allocation order as soon as we start using the tiny category. This CL is just a first step in the right direction. A follow up CL will add customizable free list categories for each old space. BUG=chromium:587026 LOG=n Committed: https://crrev.com/6b340ded84eb4c735253448454d505e15b410981 Cr-Commit-Position: refs/heads/master@{#34612}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -16 lines) Patch
M src/heap/spaces.h View 1 2 3 6 chunks +22 lines, -8 lines 0 comments Download
M src/heap/spaces.cc View 1 2 3 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Hannes Payer (out of office)
4 years, 9 months ago (2016-03-08 13:31:11 UTC) #3
Michael Lippautz
lgtm Maybe update the CL description with the results obtained from local testing. https://codereview.chromium.org/1774953003/diff/40001/src/heap/spaces.h File ...
4 years, 9 months ago (2016-03-09 09:22:11 UTC) #5
ulan
lgtm
4 years, 9 months ago (2016-03-09 09:46:11 UTC) #6
Hannes Payer (out of office)
https://codereview.chromium.org/1774953003/diff/40001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/1774953003/diff/40001/src/heap/spaces.h#newcode1791 src/heap/spaces.h:1791: // The tiny category is not used for fast ...
4 years, 9 months ago (2016-03-09 11:04:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774953003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774953003/60001
4 years, 9 months ago (2016-03-09 11:43:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774953003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774953003/60001
4 years, 9 months ago (2016-03-09 11:55:57 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-09 11:57:38 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 11:58:10 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6b340ded84eb4c735253448454d505e15b410981
Cr-Commit-Position: refs/heads/master@{#34612}

Powered by Google App Engine
This is Rietveld 408576698