third_party/WebKit/Source/web/tests/WebURLRequestTest.cpp - Issue 1774943003: blink: Rename platform/ methods to prefix with get when they collide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebURLRequestTest.cpp

Issue 1774943003: blink: Rename platform/ methods to prefix with get when they collide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clash-platform: rebase-yayyyyyyyy Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp ('k') | third_party/WebKit/Source/web/tests/WebURLResponseTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/WebURLRequestTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebURLRequestTest.cpp b/third_party/WebKit/Source/web/tests/WebURLRequestTest.cpp

index 17961389143843f984914657443be1675e0b785d..388d5a9dbb0a4ada19f77ebd3cc1856924f2068b 100644

--- a/third_party/WebKit/Source/web/tests/WebURLRequestTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebURLRequestTest.cpp

@@ -58,15 +58,15 @@ TEST(WebURLRequestTest, ExtraData)

urlRequest.initialize();

urlRequest.setExtraData(extraData);

- EXPECT_EQ(extraData, urlRequest.extraData());

+ EXPECT_EQ(extraData, urlRequest.getExtraData());

{

WebURLRequest otherUrlRequest = urlRequest;

EXPECT_TRUE(alive);

- EXPECT_EQ(extraData, otherUrlRequest.extraData());

- EXPECT_EQ(extraData, urlRequest.extraData());

+ EXPECT_EQ(extraData, otherUrlRequest.getExtraData());

+ EXPECT_EQ(extraData, urlRequest.getExtraData());

}

EXPECT_TRUE(alive);

- EXPECT_EQ(extraData, urlRequest.extraData());

+ EXPECT_EQ(extraData, urlRequest.getExtraData());

}

EXPECT_FALSE(alive);

}