third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp - Issue 1774943003: blink: Rename platform/ methods to prefix with get when they collide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp

Issue 1774943003: blink: Rename platform/ methods to prefix with get when they collide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clash-platform: rebase-yayyyyyyyy Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/ImageFilterBuilderTest.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp b/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp

index 55cddf79b558e9072ffd53ecaac15a5727d9000b..4724206d5d40f61fc02fb59c446b0d8d7a7fb7da 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp

@@ -80,7 +80,7 @@ void SkiaImageFilterBuilder::buildFilterOperations(const FilterOperations& opera

switch (op.type()) {

case FilterOperation::REFERENCE: {

RefPtr<SkImageFilter> filter;

- Filter* referenceFilter = toReferenceFilterOperation(op).filter();

+ Filter* referenceFilter = toReferenceFilterOperation(op).getFilter();

if (referenceFilter && referenceFilter->lastEffect()) {

FilterEffect* filterEffect = referenceFilter->lastEffect();

// Prepopulate SourceGraphic with two image filters: one with a null image

@@ -91,7 +91,7 @@ void SkiaImageFilterBuilder::buildFilterOperations(const FilterOperations& opera

// these for the PM-validated options.

RefPtr<SkImageFilter> deviceFilter = transformColorSpace(nullFilter, currentColorSpace, ColorSpaceDeviceRGB);

RefPtr<SkImageFilter> linearFilter = transformColorSpace(nullFilter, currentColorSpace, ColorSpaceLinearRGB);

- FilterEffect* sourceGraphic = referenceFilter->sourceGraphic();

+ FilterEffect* sourceGraphic = referenceFilter->getSourceGraphic();

sourceGraphic->setImageFilter(ColorSpaceDeviceRGB, false, deviceFilter.get());

sourceGraphic->setImageFilter(ColorSpaceLinearRGB, false, linearFilter.get());

sourceGraphic->setImageFilter(ColorSpaceDeviceRGB, true, deviceFilter.get());