third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp - Issue 1774943003: blink: Rename platform/ methods to prefix with get when they collide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp

Issue 1774943003: blink: Rename platform/ methods to prefix with get when they collide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clash-platform: rebase-yayyyyyyyy Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/SimpleFontData.h ('k') | third_party/WebKit/Source/platform/fonts/mac/FontPlatformDataMac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp b/third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp

index 12c128795ba6116862fdf91eef5ac918b49a4f91..b3eae9234ba126f0ca02c170c3ee49e93d5f322c 100644

--- a/third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp

+++ b/third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp

@@ -141,7 +141,7 @@ void SimpleFontData::platformInit()

// of the glyph may be truncated when displayed in a 'overflow: hidden' container.

// To avoid that, borrow 1 unit from the ascent when possible.

// FIXME: This can be removed if sub-pixel ascent/descent is supported.

- if (platformData().fontRenderStyle().useSubpixelPositioning && descent < SkScalarToFloat(metrics.fDescent) && ascent >= 1) {

+ if (platformData().getFontRenderStyle().useSubpixelPositioning && descent < SkScalarToFloat(metrics.fDescent) && ascent >= 1) {

++descent;

--ascent;

}