third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp - Issue 1774943003: blink: Rename platform/ methods to prefix with get when they collide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp

Issue 1774943003: blink: Rename platform/ methods to prefix with get when they collide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clash-platform: rebase-yayyyyyyyy Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp ('k') | third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp b/third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp

index dbf42f3a8f7582731307a0769649f74524d9eb0e..a904821ef2e6a1ecdc4e500bd5ec3a12512cfa4c 100644

--- a/third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp

@@ -71,16 +71,16 @@ bool SVGFEDiffuseLightingElement::setFilterEffectAttribute(FilterEffect* effect,

const SVGFELightElement* lightElement = SVGFELightElement::findLightElement(*this);

ASSERT(lightSource);

ASSERT(lightElement);

- ASSERT(effect->filter());

+ ASSERT(effect->getFilter());

if (attrName == SVGNames::azimuthAttr)

return lightSource->setAzimuth(lightElement->azimuth()->currentValue()->value());

if (attrName == SVGNames::elevationAttr)

return lightSource->setElevation(lightElement->elevation()->currentValue()->value());

if (attrName == SVGNames::xAttr || attrName == SVGNames::yAttr || attrName == SVGNames::zAttr)

- return lightSource->setPosition(effect->filter()->resolve3dPoint(lightElement->position()));

+ return lightSource->setPosition(effect->getFilter()->resolve3dPoint(lightElement->position()));

if (attrName == SVGNames::pointsAtXAttr || attrName == SVGNames::pointsAtYAttr || attrName == SVGNames::pointsAtZAttr)

- return lightSource->setPointsAt(effect->filter()->resolve3dPoint(lightElement->pointsAt()));

+ return lightSource->setPointsAt(effect->getFilter()->resolve3dPoint(lightElement->pointsAt()));

if (attrName == SVGNames::specularExponentAttr)

return lightSource->setSpecularExponent(lightElement->specularExponent()->currentValue()->value());

if (attrName == SVGNames::limitingConeAngleAttr)